Skip to content

Use an ephemeral environment for uv run --with invocations #14447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Jul 3, 2025

Summary

This PR creates separation between the --with environment and the environment we actually run in, which in turn solves issues like #12889 whereby two invocations share the same --with environment, causing them to collide by way of sharing an overlay.

Closes #7643.

@charliermarsh charliermarsh added the bug Something isn't working label Jul 3, 2025
@charliermarsh charliermarsh temporarily deployed to uv-test-registries July 3, 2025 19:38 — with GitHub Actions Inactive
@charliermarsh charliermarsh temporarily deployed to uv-test-registries July 3, 2025 19:45 — with GitHub Actions Inactive
@charliermarsh charliermarsh marked this pull request as ready for review July 3, 2025 20:26
@charliermarsh charliermarsh temporarily deployed to uv-test-registries July 3, 2025 20:28 — with GitHub Actions Inactive
@zanieb
Copy link
Member

zanieb commented Jul 3, 2025

Nice, this makes sense to me. I'll give it a closer look on Monday.

@tjni
Copy link

tjni commented Jul 9, 2025

Thank you for digging this up and fixing it. I really appreciate it!

@charliermarsh charliermarsh changed the base branch from main to release/080 July 14, 2025 17:00
@charliermarsh charliermarsh added this to the v0.8.0 milestone Jul 14, 2025
@charliermarsh charliermarsh temporarily deployed to uv-test-registries July 14, 2025 17:06 — with GitHub Actions Inactive
@charliermarsh charliermarsh merged commit 496847e into release/080 Jul 14, 2025
92 checks passed
@charliermarsh charliermarsh deleted the charlie/eph branch July 14, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv run --with should not allow modifications to the --with environment
3 participants