Skip to content

feat: add --no-default-groups flag #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 21, 2025
Merged

feat: add --no-default-groups flag #10618

merged 4 commits into from
Jan 21, 2025

Conversation

mkniewallner
Copy link
Contributor

Summary

Closes #10592.

Test Plan

Snapshot tests.

@zanieb
Copy link
Member

zanieb commented Jan 14, 2025

Should we have --no-groups or --no-default-groups?

@zanieb
Copy link
Member

zanieb commented Jan 14, 2025

I think the latter might be more versatile.

@mkniewallner
Copy link
Contributor Author

Would --no-default-groups disable tool.uv.default-groups under the hood, meaning that it would set it back to dev section only by default? If so, I believe the implementation should be changed a bit, as in that case we should not exclude all groups, but include dev group unless --no-dev is also specified?

@zanieb
Copy link
Member

zanieb commented Jan 14, 2025

I think it would exclude all groups provided via default-groups including our default dev behavior. The difference would be like...

  • --group foo --group bar --no-groups: no groups selected
  • --group foo --group bar --no-default-groups: foo and bar still selected

@mkniewallner mkniewallner force-pushed the feat/add-no-groups-flag branch from 3fed672 to 8265ef7 Compare January 15, 2025 00:58
@mkniewallner mkniewallner changed the title feat: add --no-groups flag feat: add --no-default-groups flag Jan 15, 2025
@mkniewallner mkniewallner marked this pull request as ready for review January 15, 2025 01:09
mkniewallner
mkniewallner commented Jan 15, 2025
View reviewed changes
crates/uv-configuration/src/dev.rs Outdated
Comment on lines 68 to 71
/// Explicitly include dependencies from the specified groups.
///
/// If the list is empty, no group will be included.
IncludeExplicitly(Vec<GroupName>),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find a better naming and description.

@zanieb zanieb requested a review from charliermarsh January 15, 2025 19:04
@charliermarsh charliermarsh mentioned this pull request Jan 19, 2025
Closed
@cjw296
Copy link

cjw296 commented Jan 21, 2025 •
edited
Loading

@zanieb - as you can see from the issue @charliermarsh linked, I've run into having a selection of default groups but only wanted to install only one but including the project, I think this PR should make it possible with:

uv sync --no-default-groups --group docs

This still feels a bit clunky, so open to other suggestions, but will use it if there's nothing else on offer :-)

charliermarsh
charliermarsh approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh merged commit 1479f52 into astral-sh:main Jan 21, 2025
68 checks passed
@charliermarsh charliermarsh added enhancement New feature or improvement to existing functionality cli Related to the command line interface labels Jan 21, 2025
@mkniewallner mkniewallner deleted the feat/add-no-groups-flag branch January 21, 2025 23:07
@BrewTestBot BrewTestBot mentioned this pull request Jan 23, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 26, 2025
@tmeijn
build(deps): update astral-sh/uv to v0.5.24
d345d30 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.22` -> `0.5.24` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.24`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0524)

[Compare Source](astral-sh/uv@0.5.23...0.5.24)

##### Enhancements

-   Improve determinism of resolution by always setting package priorities ([#&#8203;10853](astral-sh/uv#10853))
-   Upgrade to `cargo-dist` 0.28.0; improves several installer behaviors ([#&#8203;10884](astral-sh/uv#10884))

##### Performance

-   Remove dependencies clone in resolver ([#&#8203;10880](astral-sh/uv#10880))
-   Use Hashbrown's raw entry API to reduce hashes and clone in resolver priority determination ([#&#8203;10881](astral-sh/uv#10881))

##### Bug fixes

-   Allow fallback to Python download on non-critical discovery errors ([#&#8203;10908](astral-sh/uv#10908))

##### Preview features

-   Register managed Python version with the Windows Registry (PEP 514) ([#&#8203;10634](astral-sh/uv#10634))

##### Documentation

-   Improve documentation for some environment variables ([#&#8203;10887](astral-sh/uv#10887))
-   Add git subdirectory example ([#&#8203;10894](astral-sh/uv#10894))

### [`v0.5.23`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0523)

[Compare Source](astral-sh/uv@0.5.22...0.5.23)

##### Enhancements

-   Add `--refresh` to `uv venv` ([#&#8203;10834](astral-sh/uv#10834))
-   Add `--no-default-groups` command-line flag ([#&#8203;10618](astral-sh/uv#10618))

##### Bug fixes

-   Sort extras and groups when comparing lockfile requirements ([#&#8203;10856](astral-sh/uv#10856))
-   Include `commit_id` and `requested_revision` in `direct_url.json` ([#&#8203;10862](astral-sh/uv#10862))
-   Invalidate lockfile when static versions change ([#&#8203;10858](astral-sh/uv#10858))
-   Make GitHub fast path errors non-fatal ([#&#8203;10859](astral-sh/uv#10859))
-   Remove warnings for `--frozen` and `--locked` in `uv run --script` ([#&#8203;10840](astral-sh/uv#10840))
-   Resolve `find-links` paths relative to the configuration file ([#&#8203;10827](astral-sh/uv#10827))
-   Respect visitation order for proxy packages ([#&#8203;10833](astral-sh/uv#10833))
-   Treat version mismatch errors as non-fatal in fast paths ([#&#8203;10860](astral-sh/uv#10860))
-   Mark `--locked` and `--upgrade` are conflicting ([#&#8203;10836](astral-sh/uv#10836))
-   Relax error checking around unconditional enabling of conflicting extras ([#&#8203;10875](astral-sh/uv#10875))

##### Documentation

-   Reduce ambiguity in conflicting extras example ([#&#8203;10877](astral-sh/uv#10877))
-   Update pre-commit documentation  ([#&#8203;10756](astral-sh/uv#10756))

##### Error messages

-   Error when workspace contains conflicting Python requirements ([#&#8203;10841](astral-sh/uv#10841))
-   Improve uvx error message when uv is missing ([#&#8203;9745](astral-sh/uv#9745))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMjIuMCIsInVwZGF0ZWRJblZlciI6IjM5LjEyNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

@charliermarsh charliermarsh

Labels
cli Related to the command line interface enhancement New feature or improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to disable all dependency groups in uv sync
4 participants
@mkniewallner @zanieb @cjw296 @charliermarsh