Skip to content

Visit source distributions before wheels #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Visit source distributions before wheels #10291

merged 1 commit into from
Jan 3, 2025

Conversation

charliermarsh
Copy link
Member

Summary

This should address the comment here: #10179 (comment). We don't compute implied markers if the marker is already TRUE, and we set it to TRUE as soon as we see a source distribution. So if we visit the source distribution before the wheels, we'll avoid computing these for any irrelevant distributions.

@charliermarsh charliermarsh added the performance Potential performance improvement label Jan 3, 2025
@charliermarsh charliermarsh requested a review from konstin January 3, 2025 16:24
Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #10291 will improve performances by 15.66%

Comparing charlie/sd (c513714) with main (9f1ba2b)

Summary

⚡ 1 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/sd Change
resolve_warm_jupyter 110.7 ms 95.7 ms +15.66%

@charliermarsh charliermarsh merged commit 5b33431 into main Jan 3, 2025
64 checks passed
@charliermarsh charliermarsh deleted the charlie/sd branch January 3, 2025 17:07
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 8, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.14` -> `0.5.15` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.15`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0515)

[Compare Source](astral-sh/uv@0.5.14...0.5.15)

##### Python

The managed Python distributions have been updated, including:

-   Python 3.14.0a3 support on macOS and Linux
-   Performance improvements
-   Fixes to SQLite feature detection

See the [`python-build-standalone` release notes](https://github.com/astral-sh/python-build-standalone/releases/tag/20250106) for more details.

##### Enhancements

-   Respect `FORCE_COLOR` environment variable ([#&#8203;10315](astral-sh/uv#10315))

##### Performance

-   Avoid generating unused hashes during `uv lock` ([#&#8203;10307](astral-sh/uv#10307))
-   Visit source distributions before wheels ([#&#8203;10291](astral-sh/uv#10291))

##### Bug fixes

-   Avoid downgrading packages when `--upgrade` is provided ([#&#8203;10097](astral-sh/uv#10097))
-   Extract supported architectures from wheel tags ([#&#8203;10179](astral-sh/uv#10179))
-   Redact new index credentials in `uv add` ([#&#8203;10329](astral-sh/uv#10329))

##### Documentation

-   Clarify `exclude-newer` only allows full timestamps in settings documentation ([#&#8203;9135](astral-sh/uv#9135))
-   Tweak script `--no-project` comment ([#&#8203;10331](astral-sh/uv#10331))
-   Update copyright year ([#&#8203;10297](astral-sh/uv#10297))
-   Add instructinos for installing with Scoop ([#&#8203;10332](astral-sh/uv#10332))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS4yIiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Potential performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant