Skip to content

Backtrack to non-local versions when wheels are missing platform support #10046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented Dec 20, 2024

Summary

This is yet another variation on #9928, with a few minor changes:

  1. It only applies to local versions (e.g., 2.5.1+cpu).
  2. It only considers the non-local version as an alternative (e.g., 2.5.1).
  3. It only considers the non-local alternative if it does support the unsupported platform.
  4. Instead of failing, it falls back to using the local version.

So, this is far less strict, and is effectively designed to solve PyTorch but nothing else. It's also not user-configurable, except by way of using environments to exclude platforms.

@charliermarsh charliermarsh added the bug Something isn't working label Dec 20, 2024
@charliermarsh charliermarsh marked this pull request as ready for review December 20, 2024 03:04
@charliermarsh charliermarsh force-pushed the charlie/incomplete-locals-only branch from 9889462 to 92f133a Compare December 20, 2024 03:05
@charliermarsh charliermarsh force-pushed the charlie/incomplete-locals-only branch from 92f133a to 0a8ca2d Compare December 20, 2024 03:12
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #10046 will not alter performance

Comparing charlie/incomplete-locals-only (6b79efd) with main (f3c5b63)

Summary

✅ 14 untouched benchmarks

Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given PyTorch's setup, I feel comfortable with this. But if it's workable, I like @konstin's idea to use the complement of the implied markers instead of hard-coding the Windows/macOS/Linux platforms.

@charliermarsh charliermarsh force-pushed the charlie/incomplete-locals-only branch from 81574b0 to 14559a8 Compare December 20, 2024 18:54
@charliermarsh charliermarsh force-pushed the charlie/incomplete-locals-only branch from 14559a8 to 6b79efd Compare December 20, 2024 19:00
@charliermarsh charliermarsh enabled auto-merge (squash) December 20, 2024 19:03
@charliermarsh charliermarsh merged commit 2c68dfd into main Dec 20, 2024
64 checks passed
@charliermarsh charliermarsh deleted the charlie/incomplete-locals-only branch December 20, 2024 19:11
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 28, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.11` -> `0.5.13` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>astral-sh/uv (astral-sh/uv)</summary>

### [`v0.5.13`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0513)

[Compare Source](astral-sh/uv@0.5.12...0.5.13)

##### Bug fixes

-   Avoid enforcing URL check on initial publish ([#&#8203;10182](astral-sh/uv#10182))
-   Fix incorrect mismatched constraints reference ([#&#8203;10184](astral-sh/uv#10184))
-   Revert "Update `reqwest` ([#&#8203;10178](astral-sh/uv#10178))" ([#&#8203;10187](astral-sh/uv#10187))

### [`v0.5.12`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0512)

[Compare Source](astral-sh/uv@0.5.11...0.5.12)

##### Enhancements

-   Support `uv export` for non-project workspaces ([#&#8203;10144](astral-sh/uv#10144))
-   Set glibc versions for standalone installers ([#&#8203;10142](astral-sh/uv#10142))
-   Allow environment variables to be included in cache keys ([#&#8203;10170](astral-sh/uv#10170))

##### Preview features

-   Include extras in `uv-build` `Requires-Dist` metadata ([#&#8203;10110](astral-sh/uv#10110))
-   Use `shutil.which` for the build backend ([#&#8203;10028](astral-sh/uv#10028))

##### Bug fixes

-   Always write slash paths to RECORD file ([#&#8203;10164](astral-sh/uv#10164))
-   Add support for subdirectories in direct URLs in `uv.lock` ([#&#8203;10068](astral-sh/uv#10068))
-   Avoid duplicating backslashes in sysconfig parser ([#&#8203;10063](astral-sh/uv#10063))
-   Avoid erroring when subdirectories are provided in `uv add` ([#&#8203;10095](astral-sh/uv#10095))
-   Backtrack to non-local versions when wheels are missing platform support ([#&#8203;10046](astral-sh/uv#10046))
-   Fix mirror script to handle newer metadata format ([#&#8203;10050](astral-sh/uv#10050))
-   Preserve sort when deciding on requirement placement ([#&#8203;10078](astral-sh/uv#10078))
-   Remove redundant alias in `uv init` CLI ([#&#8203;10124](astral-sh/uv#10124))
-   Respect sources credentials in non-project workspaces ([#&#8203;10125](astral-sh/uv#10125))
-   Show non-project dependencies in `uv tree` ([#&#8203;10149](astral-sh/uv#10149))
-   Strip fragment when storing direct URL ([#&#8203;10093](astral-sh/uv#10093))
-   Include hashes for local source archives ([#&#8203;10080](astral-sh/uv#10080))

##### Documentation

-   Fix invalid syntax in some sources examples ([#&#8203;10127](astral-sh/uv#10127))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44Mi45IiwidXBkYXRlZEluVmVyIjoiMzkuODMuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
charliermarsh added a commit that referenced this pull request Jan 4, 2025
## Summary

This PR extends #10046 to also handle architectures, which allows us to
correctly include `2.5.1` on the `cu124` index for ARM Linux.

Closes #9655.
nathanpainchaud added a commit to nathanpainchaud/lightning-hydra-template that referenced this pull request Jan 14, 2025
…te deps and locked versions

Follows the updated `uv` instructions on how to install PyTorch, updated here: astral-sh/uv#10046
nathanpainchaud added a commit to nathanpainchaud/lightning-hydra-template that referenced this pull request Jan 14, 2025
…te deps and locked versions

Follows the updated `uv` instructions on how to install PyTorch, updated here: astral-sh/uv#10046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants