Skip to content

Batch prefetch per fork #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/uv-resolver/src/resolver/batch_prefetch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ enum BatchPrefetchStrategy {
/// have to fetch the metadata for a lot of versions.
///
/// Note that these all heuristics that could totally prefetch lots of irrelevant versions.
#[derive(Clone)]
pub(crate) struct BatchPrefetcher {
// Internal types.
tried_versions: FxHashMap<PackageName, usize>,
Expand Down
21 changes: 16 additions & 5 deletions crates/uv-resolver/src/resolver/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -310,12 +310,17 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag

let root = PubGrubPackage::from(PubGrubPackageInner::Root(self.project.clone()));
let pubgrub = State::init(root.clone(), MIN_VERSION.clone());
let mut prefetcher = BatchPrefetcher::new(
let prefetcher = BatchPrefetcher::new(
self.capabilities.clone(),
self.index.clone(),
request_sink.clone(),
);
let state = ForkState::new(pubgrub, self.env.clone(), self.python_requirement.clone());
let state = ForkState::new(
pubgrub,
self.env.clone(),
self.python_requirement.clone(),
prefetcher,
);
let mut preferences = self.preferences.clone();
let mut forked_states = self.env.initial_forked_states(state);
let mut resolutions = vec![];
Expand Down Expand Up @@ -393,7 +398,7 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
else {
// All packages have been assigned, the fork has been successfully resolved
if tracing::enabled!(Level::DEBUG) {
prefetcher.log_tried_versions();
state.prefetcher.log_tried_versions();
}
debug!(
"{} resolution took {:.3}s",
Expand Down Expand Up @@ -472,7 +477,7 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag
// (idempotent due to caching).
self.request_package(next_package, url, index, &request_sink)?;

prefetcher.version_tried(next_package);
state.prefetcher.version_tried(next_package);

let term_intersection = state
.pubgrub
Expand Down Expand Up @@ -545,7 +550,7 @@ impl<InstalledPackages: InstalledPackagesProvider> ResolverState<InstalledPackag

// Only consider registry packages for prefetch.
if url.is_none() {
prefetcher.prefetch_batches(
state.prefetcher.prefetch_batches(
next_package,
index,
&version,
Expand Down Expand Up @@ -2259,13 +2264,18 @@ pub(crate) struct ForkState {
/// solution that omits Python 3.8 support.
python_requirement: PythonRequirement,
conflict_tracker: ConflictTracker,
/// Prefetch package versions for packages with many rejected versions.
///
/// Tracked on the fork state to avoid counting each identical version between forks as new try.
prefetcher: BatchPrefetcher,
}

impl ForkState {
fn new(
pubgrub: State<UvDependencyProvider>,
env: ResolverEnvironment,
python_requirement: PythonRequirement,
prefetcher: BatchPrefetcher,
) -> Self {
Self {
initial: None,
Expand All @@ -2279,6 +2289,7 @@ impl ForkState {
env,
python_requirement,
conflict_tracker: ConflictTracker::default(),
prefetcher,
}
}

Expand Down
Loading