Skip to content

Support allow-insecure-host in uv python #6985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zanieb opened this issue Sep 3, 2024 · 4 comments
Open

Support allow-insecure-host in uv python #6985

zanieb opened this issue Sep 3, 2024 · 4 comments
Labels
enhancement New feature or improvement to existing functionality help wanted Contribution especially encouraged

Comments

@zanieb
Copy link
Member

zanieb commented Sep 3, 2024 •
edited
Loading

Currently, we do not read this setting during Python downloads.

See #6983 for some beginning changes. We'll need to change the internal structuring of the settings a bit to support this.
@zanieb zanieb added the enhancement New feature or improvement to existing functionality label Sep 3, 2024
@zanieb
Copy link
Member Author

zanieb commented Sep 3, 2024

@charliermarsh are you opposed to this / moving the setting to a global option or can I mark this as help wanted?

@charliermarsh
Copy link
Member

@zanieb -- That seems ok to me. Should keyring also be global?

@zanieb
Copy link
Member Author

zanieb commented Sep 4, 2024

@charliermarsh Maybe. I don't see an obvious use-case for it but the network settings make sense for anything that's going to perform requests. Maybe we should move all the network options into a dedicated struct / section?

@charliermarsh
Copy link
Member

charliermarsh commented Sep 5, 2024 •
edited
Loading

@zanieb -- Yeah I support that! (Dedicated struct etc.)

@zanieb zanieb added the help wanted Contribution especially encouraged label Sep 7, 2024
@j178 j178 mentioned this issue Oct 22, 2024
Closed
konstin added a commit that referenced this issue Oct 22, 2024
@konstin
Respect allow insecure host in publish
2854563 
Switch to respecting the allow insecure host setting in all places where we use the client.

Fixes #8423
Part of #6985
Doesn't touch #6983
@konstin konstin mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement to existing functionality help wanted Contribution especially encouraged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charliermarsh @zanieb