Skip to content

Question: Pass in ClientWithMiddleware to RegistryClient and Builder #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tdejager opened this issue May 6, 2024 · 0 comments
Open
Labels
rustlib Related to our Rust library API

Comments

@tdejager
Copy link
Contributor

tdejager commented May 6, 2024

For use in pixi, it would be great if we could use our own middleware for the Reqwest Client, instead of having to rely on the middleware that uv provides :)

Would you guys be open for directly accepting a ClientWithMiddleware in the RegistryClient (I could make a PR for this)? I think this addition maybe does not make a lot of sense from a uv-as-a-binary perspective, as you most likely want to control your own middleware. But I believe it does make sense from a library perspective, as library users can add their own authentication middleware and whatnot. There is an open question in the design if it should be layered on top of your middleware or replace it, again from a library perspective I think replacing it make sense.

How would you feel about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rustlib Related to our Rust library API
Projects
None yet
Development

No branches or pull requests

2 participants