Memoize filesystem operations during unpack #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/memo
branch
from
8a0cfa7 to
485bd2d
Compare
charliermarsh
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 3, 2025
## Summary I shipped one security fix here along with several significant performance improvements for large TAR files: - astral-sh/tokio-tar#2 - astral-sh/tokio-tar#4 - astral-sh/tokio-tar#5 I also PR'd the security fix to `edera-dev` (edera-dev/tokio-tar#4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
dstis the same throughout the life of the unpack, and we canonicalize it before unpacking. So we can avoid re-validating and re-canonicalizing for every single archive entry.For a large PyTorch wheel, this improves performance by about 12.5%.