Remove WithItem<"as"> goal

[MichaReiser]

Summary

I found the negation difficult to reason about. That's why I extracted a new WithItemAs rule instead.

Test Plan

cargo test

[MichaReiser]

Current dependencies on/for this PR:

• main
  • PR Rename parser goal 'All' to 'all' #6867
    • PR Remove WithItem<"as"> goal #6868 👈

This comment was auto-generated by Graphite.

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.06      4.6±0.27ms     8.9 MB/sec    1.00      4.3±0.27ms     9.5 MB/sec
formatter/numpy/ctypeslib.py               1.08   959.4±50.72µs    17.4 MB/sec    1.00   886.0±50.99µs    18.8 MB/sec
formatter/numpy/globals.py                 1.00     84.8±4.89µs    34.8 MB/sec    1.05     89.0±7.92µs    33.2 MB/sec
formatter/pydantic/types.py                1.02  1756.9±86.90µs    14.5 MB/sec    1.00  1726.1±97.02µs    14.8 MB/sec
linter/all-rules/large/dataset.py          1.04     12.3±0.57ms     3.3 MB/sec    1.00     11.8±0.58ms     3.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.10ms     5.1 MB/sec    1.00      3.3±0.20ms     5.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   450.1±30.37µs     6.6 MB/sec    1.03   464.2±19.02µs     6.4 MB/sec
linter/all-rules/pydantic/types.py         1.03      6.5±0.36ms     3.9 MB/sec    1.00      6.3±0.24ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.00      6.4±0.45ms     6.3 MB/sec    1.00      6.4±0.18ms     6.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1360.1±77.13µs    12.2 MB/sec    1.04  1419.3±61.53µs    11.7 MB/sec
linter/default-rules/numpy/globals.py      1.04    165.0±9.58µs    17.9 MB/sec    1.00    158.9±9.19µs    18.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      2.9±0.17ms     8.8 MB/sec    1.03      3.0±0.15ms     8.6 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      5.5±0.12ms     7.4 MB/sec    1.00      5.4±0.10ms     7.5 MB/sec
formatter/numpy/ctypeslib.py               1.00  1115.4±26.13µs    14.9 MB/sec    1.00  1111.9±24.55µs    15.0 MB/sec
formatter/numpy/globals.py                 1.00    107.8±3.00µs    27.4 MB/sec    1.03    110.5±5.11µs    26.7 MB/sec
formatter/pydantic/types.py                1.00      2.2±0.09ms    11.4 MB/sec    1.00      2.2±0.06ms    11.4 MB/sec
linter/all-rules/large/dataset.py          1.02     14.7±0.09ms     2.8 MB/sec    1.00     14.4±0.22ms     2.8 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      4.1±0.05ms     4.1 MB/sec    1.00      4.0±0.06ms     4.2 MB/sec
linter/all-rules/numpy/globals.py          1.02    516.0±6.32µs     5.7 MB/sec    1.00    503.5±8.20µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.02      7.6±0.06ms     3.3 MB/sec    1.00      7.4±0.08ms     3.4 MB/sec
linter/default-rules/large/dataset.py      1.05      8.2±0.15ms     5.0 MB/sec    1.00      7.9±0.07ms     5.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.07  1816.4±27.78µs     9.2 MB/sec    1.00  1694.1±39.21µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.05    209.6±3.24µs    14.1 MB/sec    1.00    200.1±4.48µs    14.7 MB/sec
linter/default-rules/pydantic/types.py     1.06      3.7±0.06ms     6.9 MB/sec    1.00      3.5±0.05ms     7.2 MB/sec