[flake8-use-pathlib] Add autofixes for PTH203, PTH204, PTH205

crates/ruff_linter/resources/test/fixtures/flake8_use_pathlib/PTH203.py

@@ -1,12 +1,81 @@
+import pathlib
 import os.path
 from pathlib import Path
 from os.path import getatime
 
+filename = "filename"
+filename1 = __file__
+filename2 = Path("filename")
+
+
 os.path.getatime("filename")
 os.path.getatime(b"filename")
 os.path.getatime(Path("filename"))
+os.path.getatime(__file__)
 
+os.path.getatime(filename)
+os.path.getatime(filename1)
+os.path.getatime(filename2)
+
+os.path.getatime(filename="filename")
+os.path.getatime(filename=b"filename")
+os.path.getatime(filename=Path("filename"))
+os.path.getatime(filename=__file__)
 
 getatime("filename")
 getatime(b"filename")
 getatime(Path("filename"))
+getatime(__file__)
+
+getatime(filename="filename")
+getatime(filename=b"filename")
+getatime(filename=Path("filename"))
+getatime(filename=__file__)
+
+getatime(filename)
+getatime(filename1)
+getatime(filename2)
+
+
+os.path.getatime(
+    "filename", # comment
+)
+
+os.path.getatime(
+    # comment
+    "filename"
+    ,
+    # comment
+)
+
+os.path.getatime(
+    # comment
+    b"filename"
+    # comment
+)
+
+os.path.getatime( # comment
+    Path(__file__)
+    # comment
+) # comment
+
+getatime( # comment
+    "filename")
+
+getatime( # comment
+    b"filename",
+    #comment
+)
+
+os.path.getatime("file" + "name")
+
+getatime \
+ \
+ \
+        ( # comment
+        "filename",
+    )
+
+getatime(Path("filename").resolve())
+
+os.path.getatime(pathlib.Path("filename"))

crates/ruff_linter/resources/test/fixtures/flake8_use_pathlib/PTH204.py

@@ -1,13 +1,81 @@
+import pathlib
 import os.path
 from pathlib import Path
 from os.path import getmtime
 
+filename = "filename"
+filename1 = __file__
+filename2 = Path("filename")
+
 
 os.path.getmtime("filename")
 os.path.getmtime(b"filename")
 os.path.getmtime(Path("filename"))
+os.path.getmtime(__file__)
+
+os.path.getmtime(filename)
+os.path.getmtime(filename1)
+os.path.getmtime(filename2)
 
+os.path.getmtime(filename="filename")
+os.path.getmtime(filename=b"filename")
+os.path.getmtime(filename=Path("filename"))
+os.path.getmtime(filename=__file__)
 
 getmtime("filename")
 getmtime(b"filename")
 getmtime(Path("filename"))
+getmtime(__file__)
+
+getmtime(filename="filename")
+getmtime(filename=b"filename")
+getmtime(filename=Path("filename"))
+getmtime(filename=__file__)
+
+getmtime(filename)
+getmtime(filename1)
+getmtime(filename2)
+
+
+os.path.getmtime(
+    "filename", # comment
+)
+
+os.path.getmtime(
+    # comment
+    "filename"
+    ,
+    # comment
+)
+
+os.path.getmtime(
+    # comment
+    b"filename"
+    # comment
+)
+
+os.path.getmtime( # comment
+    Path(__file__)
+    # comment
+) # comment
+
+getmtime( # comment
+    "filename")
+
+getmtime( # comment
+    b"filename",
+    #comment
+)
+
+os.path.getmtime("file" + "name")
+
+getmtime \
+ \
+ \
+        ( # comment
+        "filename",
+    )
+
+getmtime(Path("filename").resolve())
+
+os.path.getmtime(pathlib.Path("filename"))

crates/ruff_linter/resources/test/fixtures/flake8_use_pathlib/PTH205.py

@@ -1,12 +1,81 @@
+import pathlib
 import os.path
 from pathlib import Path
 from os.path import getctime
 
+filename = "filename"
+filename1 = __file__
+filename2 = Path("filename")
+
 
 os.path.getctime("filename")
 os.path.getctime(b"filename")
 os.path.getctime(Path("filename"))
+os.path.getctime(__file__)
+
+os.path.getctime(filename)
+os.path.getctime(filename1)
+os.path.getctime(filename2)
+
+os.path.getctime(filename="filename")
+os.path.getctime(filename=b"filename")
+os.path.getctime(filename=Path("filename"))
+os.path.getctime(filename=__file__)
 
 getctime("filename")
 getctime(b"filename")
 getctime(Path("filename"))
+getctime(__file__)
+
+getctime(filename="filename")
+getctime(filename=b"filename")
+getctime(filename=Path("filename"))
+getctime(filename=__file__)
+
+getctime(filename)
+getctime(filename1)
+getctime(filename2)
+
+
+os.path.getctime(
+    "filename", # comment
+)
+
+os.path.getctime(
+    # comment
+    "filename"
+    ,
+    # comment
+)
+
+os.path.getctime(
+    # comment
+    b"filename"
+    # comment
+)
+
+os.path.getctime( # comment
+    Path(__file__)
+    # comment
+) # comment
+
+getctime( # comment
+    "filename")
+
+getctime( # comment
+    b"filename",
+    #comment
+)
+
+os.path.getctime("file" + "name")
+
+getctime \
+ \
+ \
+        ( # comment
+        "filename",
+    )
+
+getctime(Path("filename").resolve())
+
+os.path.getctime(pathlib.Path("filename"))

crates/ruff_linter/src/checkers/ast/analyze/expression.rs

@@ -1056,9 +1056,6 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
                 Rule::OsPathSplitext,
                 Rule::BuiltinOpen,
                 Rule::PyPath,
-                Rule::OsPathGetatime,
-                Rule::OsPathGetmtime,
-                Rule::OsPathGetctime,
                 Rule::Glob,
                 Rule::OsListdir,
                 Rule::OsSymlink,
@@ -1068,6 +1065,15 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
             if checker.is_rule_enabled(Rule::OsPathGetsize) {
                 flake8_use_pathlib::rules::os_path_getsize(checker, call);
             }
+            if checker.is_rule_enabled(Rule::OsPathGetatime) {
+                flake8_use_pathlib::rules::os_path_getatime(checker, call);
+            }
+            if checker.is_rule_enabled(Rule::OsPathGetctime) {
+                flake8_use_pathlib::rules::os_path_getctime(checker, call);
+            }
+            if checker.is_rule_enabled(Rule::OsPathGetmtime) {
+                flake8_use_pathlib::rules::os_path_getmtime(checker, call);
+            }
             if checker.is_rule_enabled(Rule::PathConstructorCurrentDirectory) {
                 flake8_use_pathlib::rules::path_constructor_current_directory(checker, call);
             }

crates/ruff_linter/src/preview.rs

@@ -54,6 +54,20 @@ pub(crate) const fn is_fix_manual_list_comprehension_enabled(settings: &LinterSe
 pub(crate) const fn is_fix_os_path_getsize_enabled(settings: &LinterSettings) -> bool {
     settings.preview.is_enabled()
 }
+// https://github.com/astral-sh/ruff/pull/18922
+pub(crate) const fn is_fix_os_path_getmtime_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
+// https://github.com/astral-sh/ruff/pull/18922
+pub(crate) const fn is_fix_os_path_getatime_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
+
+// https://github.com/astral-sh/ruff/pull/18922
+pub(crate) const fn is_fix_os_path_getctime_enabled(settings: &LinterSettings) -> bool {
+    settings.preview.is_enabled()
+}
 
 // https://github.com/astral-sh/ruff/pull/11436
 // https://github.com/astral-sh/ruff/pull/11168

crates/ruff_linter/src/rules/flake8_use_pathlib/helpers.rs

@@ -0,0 +1,11 @@
+use crate::checkers::ast::Checker;
+use ruff_python_ast::Expr;
+
+pub(crate) fn is_path_call(checker: &Checker, expr: &Expr) -> bool {
+    expr.as_call_expr().is_some_and(|expr_call| {
+        checker
+            .semantic()
+            .resolve_qualified_name(&expr_call.func)
+            .is_some_and(|name| matches!(name.segments(), ["pathlib", "Path"]))
+    })
+}

crates/ruff_linter/src/rules/flake8_use_pathlib/mod.rs

@@ -1,4 +1,5 @@
 //! Rules from [flake8-use-pathlib](https://pypi.org/project/flake8-use-pathlib/).
+mod helpers;
 pub(crate) mod rules;
 pub(crate) mod violations;
 
@@ -81,6 +82,9 @@ mod tests {
 
     #[test_case(Rule::OsPathGetsize, Path::new("PTH202.py"))]
     #[test_case(Rule::OsPathGetsize, Path::new("PTH202_2.py"))]
+    #[test_case(Rule::OsPathGetatime, Path::new("PTH203.py"))]
+    #[test_case(Rule::OsPathGetmtime, Path::new("PTH204.py"))]
+    #[test_case(Rule::OsPathGetctime, Path::new("PTH205.py"))]
     fn preview_flake8_use_pathlib(rule_code: Rule, path: &Path) -> Result<()> {
         let snapshot = format!(
             "preview__{}_{}",