Skip to content

[ty] CLI reference #17978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

[ty] CLI reference #17978

merged 2 commits into from
May 9, 2025

Conversation

MichaReiser
Copy link
Member

No description provided.

@MichaReiser MichaReiser added documentation Improvements or additions to documentation ty Multi-file analysis & type inference labels May 9, 2025
MichaReiser
MichaReiser commented May 9, 2025
View reviewed changes
crates/ty/src/lib.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed access to Args (now Cli) which is why I had to introduce a lib.rs.

To avoid repeating the mod in both lib and main.rs, I decided to move the run logic to lib.rs

MichaReiser
MichaReiser commented May 9, 2025
View reviewed changes
crates/ruff_dev/src/generate_ty_cli_reference.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy paste from uv

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

mypy_primer results

No ecosystem changes detected ✅

@MichaReiser MichaReiser force-pushed the micha/ty-cli-reference branch from 4628da7 to 86b8838 Compare May 9, 2025 12:03
@MichaReiser MichaReiser marked this pull request as ready for review May 9, 2025 12:04
@MichaReiser
Copy link
Member Author

I'll merge this without review. This is all code that's easy to replace if anyone dares to touch it 😅

MichaReiser
MichaReiser commented May 9, 2025
View reviewed changes
crates/ruff_dev/Cargo.toml
@@ -32,6 +33,7 @@ imara-diff = { workspace = true }
indicatif = { workspace = true }
itertools = { workspace = true }
libcst = { workspace = true }
markdown = { version = "1.0.0" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit unfortunate but implementing a markdown to HTML converter is a bit out of scope right now ;)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

mesonbuild/meson-python (error) 

warning: Detected debug build without --no-cache.
error: Failed to read tests/packages/symlinks/baz.py: No such file or directory (os error 2)
error: Failed to read tests/packages/symlinks/qux.py: No such file or directory (os error 2)

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

mesonbuild/meson-python (error) 

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read tests/packages/symlinks/baz.py: No such file or directory (os error 2)
error: Failed to read tests/packages/symlinks/qux.py: No such file or directory (os error 2)

@MichaReiser MichaReiser force-pushed the micha/ty-cli-reference branch from f767190 to 0a8ce23 Compare May 9, 2025 12:15
@MichaReiser MichaReiser mentioned this pull request May 9, 2025
Merged
@MichaReiser MichaReiser merged commit c1b8757 into main May 9, 2025
35 checks passed
@MichaReiser MichaReiser deleted the micha/ty-cli-reference branch May 9, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ty Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MichaReiser