[red-knot] Add more tests for * imports
#17315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
testing
|
|
This is a somewhat large PR, but I'm going to "bias towards action" and merge without review: I want to rebase #17286 on top of it, land that PR and then move onto other tasks. This PR also only makes changes to our test suite, not to any of our functionality. If anybody has any comments around any of the changes here, I'm very happy to tackle them in followup PRs! Tests don't seem to be running in CI here... but I ran the tests locally so I'm pretty confident this won't break |
dcreager
added a commit
that referenced
this pull request
Apr 9, 2025
* main: [red-knot] Allow explicit specialization of generic classes (#17023) [`airflow`] Refactor `AIR301` logic and fix typos (`AIR301`) (#17293) [`airflow`] Extract `AIR312` from `AIR302` rules (`AIR302`, `AIR312`) (#17152) [red-knot] Improve handling of visibility constraints in external modules when resolving `*` imports (#17286) [red-knot] Add more tests for `*` imports (#17315)
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
exporter.pyand the second of theseimporter.py.Test Plan
uvx pre-commit run -acargo test -p red_knot_python_semantic