[red-knot] Fix playground crashes when diagnostics are stale #17165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
playground
MichaReiser
force-pushed
the
micha/playground-fix-stale-diagnostics
branch
from
508f6a9 to
da3a092
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash in the playground caused by stale diagnostics by eagerly converting diagnostic information.
- Replace method calls with property accesses for diagnostic fields.
- Rename the file open callback from onOpenFile to onFileOpened across the code.
- Eagerly serialize diagnostics in Chrome.tsx for improved error handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| playground/knot/src/Editor/Editor.tsx | Updated diagnostic and file open callback handling. |
| playground/knot/src/Editor/Diagnostics.tsx | Changed diagnostic property accesses and removed workspace use. |
| playground/knot/src/Editor/Chrome.tsx | Renamed callback prop and updated diagnostic conversion logic. |
|
Copilot oversimplifies things here. We still need to call the WASM methods and that requires using |
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: [red-knot] Fix more [redundant-cast] false positives (#17170) [red-knot] Three-argument type-calls take 'str' as the first argument (#17168) Control flow: `return` and `raise` (#17121) Bump 0.11.3 (#17173) [red-knot] Improve `Debug` implementation for `semantic_index::SymbolTable` (#17172) [red-knot] Fix `str(…)` calls (#17163) [red-knot] visibility_constraint analysis for match cases (#17077) [red-knot] Fix playground crashes when diagnostics are stale (#17165)
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (82 commits) [red-knot] Fix more [redundant-cast] false positives (#17170) [red-knot] Three-argument type-calls take 'str' as the first argument (#17168) Control flow: `return` and `raise` (#17121) Bump 0.11.3 (#17173) [red-knot] Improve `Debug` implementation for `semantic_index::SymbolTable` (#17172) [red-knot] Fix `str(…)` calls (#17163) [red-knot] visibility_constraint analysis for match cases (#17077) [red-knot] Fix playground crashes when diagnostics are stale (#17165) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) ...
maxmynter
pushed a commit
to maxmynter/ruff
that referenced
this pull request
Apr 3, 2025
…sh#17165) ## Summary Fixes a crash in the playground where it crashed with an "index out of bounds" error in the `Diagnostic::to_range` call after deleting content at the end of the file. The root cause was that the playground uses `useDeferred` to avoid too frequent `checkFile` calls (to get a smoother UX). However, this has the problem that the rendered `diagnostics` can be stable (from before the last change). Rendering the diagnostics can then fail because the `toRange` call queries the latest content and not the content from when the diagnostics were created. The fix is "easy" in the sense that we now eagerly perform the `toRange` calls. This way, it doesn't matter when the diagnostics are stale for a few ms. This problem can only be observed on examples where Red Knot is "slow" (takes more than ~16ms to check) because only then does `useDeferred` "debounce" the `check` calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in the playground where it crashed with an "index out of bounds" error in the
Diagnostic::to_rangecallafter deleting content at the end of the file.
The root cause was that the playground uses
useDeferredto avoid too frequentcheckFilecalls (to get a smoother UX).However, this has the problem that the rendered
diagnosticscan be stable (from before the last change).Rendering the diagnostics can then fail because the
toRangecall queries the latest content and not the contentfrom when the diagnostics were created.
The fix is "easy" in the sense that we now eagerly perform the
toRangecalls. This way, it doesn't matterwhen the diagnostics are stale for a few ms.
This problem can only be observed on examples where Red Knot is "slow" (takes more than ~16ms to check) because
only then does
useDeferred"debounce" thecheckcalls.