Skip to content

[pycodestyle] Auto-fix redundant boolean comparison (E712) #17090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 23, 2025
Merged

[pycodestyle] Auto-fix redundant boolean comparison (E712) #17090

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a6c711
feat: add redundant boolean comparison
knavdeep152002 Mar 31, 2025
7c7a250
refactor: redundant boolean comparison and its respective check
knavdeep152002 Apr 2, 2025
649eff8
Update snapshots for E712 rule changes"
knavdeep152002 Apr 2, 2025
5c30c97
feat: check redundant_boolean_comparison for left expression and move…
knavdeep152002 Apr 3, 2025
03d6275
fix: typo on comment
knavdeep152002 Apr 3, 2025
1118724
fix: wrap in parenthesis for right side boolean comparator case
knavdeep152002 Apr 7, 2025
63258a6
chore: run cargo fmt
knavdeep152002 Apr 8, 2025
f45c98b
Update crates/ruff_linter/src/rules/pycodestyle/rules/literal_compari…
knavdeep152002 Apr 15, 2025
2cd6971
refactor: redundant comparison
knavdeep152002 Apr 15, 2025
246c858
refactor: move helper fn to main file instead of pub fn
knavdeep152002 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions crates/ruff_python_ast/src/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,24 @@ fn is_empty_f_string(expr: &ast::ExprFString) -> bool {
})
}

fn is_redundant_boolean_comparison(op: CmpOp, comparator: &Expr) -> (bool, bool) {
match op {
CmpOp::Is => {
if let Expr::BooleanLiteral(ast::ExprBooleanLiteral { value, .. }) = comparator {
return (true, *value);
}
(false, false)
}
CmpOp::IsNot => {
if let Expr::BooleanLiteral(ast::ExprBooleanLiteral { value, .. }) = comparator {
return (true, !*value);
}
(false, false)
}
_ => (false, false),
}
}

pub fn generate_comparison(
left: &Expr,
ops: &[CmpOp],
Expand All @@ -1373,6 +1391,17 @@ pub fn generate_comparison(
.unwrap_or(left.range())],
);

if ops.len() == 1 {
let (op, comparator) = (ops[0], &comparators[0]);
if let (true, kind) = is_redundant_boolean_comparison(op, comparator) {
return if kind {
contents
} else {
format!("not {contents}")
};
}
}

for (op, comparator) in ops.iter().zip(comparators) {
// Add the operator.
contents.push_str(match op {
Expand Down
Loading