Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airflow] Add autofix for AIR302 method checks #16976

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Mar 26, 2025

Summary

Add autofix logic to AIR302 check_method

Test Plan

test fixtures have been updated accordingly

@Lee-W
Copy link
Contributor Author

Lee-W commented Mar 26, 2025

based on #16975

Copy link
Contributor

github-actions bot commented Mar 26, 2025

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

openai/openai-cookbook (error)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select A,E703,F704,B015,B018,D100

Failed to clone openai/openai-cookbook: error: 4282 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

Linter (preview)

✅ ecosystem check detected no linter changes.

@Lee-W Lee-W force-pushed the autofix-AIR302-check-method branch from 5968cc9 to cbca58d Compare March 27, 2025 03:52
@Lee-W Lee-W marked this pull request as ready for review March 27, 2025 19:35
@Lee-W Lee-W force-pushed the autofix-AIR302-check-method branch 2 times, most recently from 7388a5c to f7174ea Compare March 31, 2025 10:49
@Lee-W Lee-W mentioned this pull request Mar 31, 2025
2 tasks
@dhruvmanila dhruvmanila added fixes Related to suggested fixes for violations preview Related to preview mode features labels Mar 31, 2025
@dhruvmanila dhruvmanila changed the title [airflow] add autofix to AIR302 check_method [airflow] Add autofix for AIR302 method checks Mar 31, 2025
@Lee-W Lee-W force-pushed the autofix-AIR302-check-method branch from f7174ea to 0bbe4ab Compare April 1, 2025 03:26
@Lee-W Lee-W force-pushed the autofix-AIR302-check-method branch from 0bbe4ab to d362b7b Compare April 2, 2025 09:59
@dhruvmanila dhruvmanila merged commit 5d57788 into astral-sh:main Apr 2, 2025
22 checks passed
dcreager added a commit that referenced this pull request Apr 3, 2025
* origin/main: (35 commits)
  [red-knot] Callable types are disjoint from literals (#17160)
  [red-knot] Fix inference for `pow` between two literal integers (#17161)
  [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150)
  [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145)
  [red-knot] Add initial set of tests for unreachable code (#17159)
  [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151)
  ruff_db: simplify lifetimes on `DiagnosticDisplay`
  [red-knot] Detect division-by-zero in unions and intersections (#17157)
  [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965)
  [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136)
  [`airflow`] Add autofix for `AIR302` attribute checks (#16977)
  [`airflow`] Extend `AIR302` with additional symbols (#17085)
  [`airflow`] Move `AIR301` to `AIR002` (#16978)
  [`airflow`] Add autofix for `AIR302` method checks (#16976)
  ruff_db: switch diagnostic rendering over to `std::fmt::Display`
  [red-knot] Add 'Goto type definition' to the playground (#17055)
  red_knot_ide: update snapshots
  red_knot_python_semantic: remove comment about `TypeCheckDiagnostic`
  ruff_db: delete most of the old diagnostic code
  red_knot: use `Diagnostic` inside of red knot
  ...
maxmynter pushed a commit to maxmynter/ruff that referenced this pull request Apr 3, 2025
## Summary

Add autofix logic to `AIR302` method checks

## Test Plan

Test fixtures have been updated accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Related to suggested fixes for violations preview Related to preview mode features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants