Require explicit opt-in for GitHub and Gitlab formats #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

charliermarsh merged 1 commit into main from charlie/explicit

Jan 6, 2023

Member

charliermarsh commented Jan 6, 2023

No description provided.

Member Author

charliermarsh commented Jan 6, 2023

\cc @edgarrmondragon - Does this seem reasonable to you? I think folks will find it surprising that this behavior happens automatically, rather than via explicit configuration or a dedicated action.

charliermarsh force-pushed the charlie/explicit branch from 3a2e580 to 07dccd4 Compare

January 6, 2023 20:15


          Require explicit opt-in for GitHub and Gitlab formats

000eba5

charliermarsh force-pushed the charlie/explicit branch from 07dccd4 to 000eba5 Compare

January 6, 2023 20:21

Contributor

edgarrmondragon commented Jan 6, 2023

\cc @edgarrmondragon - Does this seem reasonable to you? I think folks will find it surprising that this behavior happens automatically, rather than via explicit configuration or a dedicated action.

@charliermarsh Yeah, I was following what other tools do (e.g. https://github.com/pytest-dev/pytest-github-actions-annotate-failures) but it makes sense to be explicit.

charliermarsh merged commit 12d2526 into main

charliermarsh deleted the charlie/explicit branch

January 6, 2023 20:57

bruxisma referenced this pull request in ixm-one/pytest-cmake-presets


          ⬆️ Update dependency ruff to ^0.0.213 (#24)

f7cabd4

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.212` ->
`^0.0.213` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.213/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.213/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.213/compatibility-slim/0.0.212)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.213/confidence-slim/0.0.212)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.213`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.213)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.212...v0.0.213)

#### What's Changed

- Remove Result from SourceCodeGenerator signature by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1677](https://togithub.com/charliermarsh/ruff/pull/1677)
- Implement `From` conversion for style detector-to-generator by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1678](https://togithub.com/charliermarsh/ruff/pull/1678)
- Replace `toml` with `toml_edit` by
[@&#8203;messense](https://togithub.com/messense) in
[https://github.com/charliermarsh/ruff/pull/1680](https://togithub.com/charliermarsh/ruff/pull/1680)
- Tweak badge logo by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1681](https://togithub.com/charliermarsh/ruff/pull/1681)
- Don't mark D205 as fixable in more-lines case by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1682](https://togithub.com/charliermarsh/ruff/pull/1682)
- Add requested context to issue template by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1679](https://togithub.com/charliermarsh/ruff/pull/1679)
- Update `CONTRIBUTING.md` location on `README.md` by
[@&#8203;saadmk11](https://togithub.com/saadmk11) in
[https://github.com/charliermarsh/ruff/pull/1688](https://togithub.com/charliermarsh/ruff/pull/1688)
- Implement flake8-simplify SIM108 by
[@&#8203;messense](https://togithub.com/messense) in
[https://github.com/charliermarsh/ruff/pull/1684](https://togithub.com/charliermarsh/ruff/pull/1684)
- Remove TODO comment by [@&#8203;harupy](https://togithub.com/harupy)
in
[https://github.com/charliermarsh/ruff/pull/1691](https://togithub.com/charliermarsh/ruff/pull/1691)
- Add specialized conversions for RefEquality by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1689](https://togithub.com/charliermarsh/ruff/pull/1689)
- Avoiding flagging elif statements as potential ternaries by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1694](https://togithub.com/charliermarsh/ruff/pull/1694)
- \[`flake8-bandit`] Add Rule for `S113` (requests call without timeout)
by [@&#8203;saadmk11](https://togithub.com/saadmk11) in
[https://github.com/charliermarsh/ruff/pull/1692](https://togithub.com/charliermarsh/ruff/pull/1692)
- Implement flake8-simplify SIM109 by
[@&#8203;messense](https://togithub.com/messense) in
[https://github.com/charliermarsh/ruff/pull/1687](https://togithub.com/charliermarsh/ruff/pull/1687)
- Simplify SIM201, SIM202, SIM208 by
[@&#8203;chammika-become](https://togithub.com/chammika-become) in
[https://github.com/charliermarsh/ruff/pull/1666](https://togithub.com/charliermarsh/ruff/pull/1666)
- \[`flake8-bandit`] Add Rule for `S501` (request call with
`verify=False`) by [@&#8203;saadmk11](https://togithub.com/saadmk11) in
[https://github.com/charliermarsh/ruff/pull/1695](https://togithub.com/charliermarsh/ruff/pull/1695)
- Require explicit opt-in for GitHub and Gitlab formats by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1697](https://togithub.com/charliermarsh/ruff/pull/1697)
- Include error location in GitHub Action diagnostic messages by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1696](https://togithub.com/charliermarsh/ruff/pull/1696)
- Include list of fixed files in `stderr` output by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1701](https://togithub.com/charliermarsh/ruff/pull/1701)
- Remove redundant #!\[allow()] from main_native by
[@&#8203;andersk](https://togithub.com/andersk) in
[https://github.com/charliermarsh/ruff/pull/1703](https://togithub.com/charliermarsh/ruff/pull/1703)
- Forbid unsafe code by [@&#8203;andersk](https://togithub.com/andersk)
in
[https://github.com/charliermarsh/ruff/pull/1704](https://togithub.com/charliermarsh/ruff/pull/1704)
- Switch SourceCodeGenerator.buffer from Vec<u8> to String by
[@&#8203;andersk](https://togithub.com/andersk) in
[https://github.com/charliermarsh/ruff/pull/1702](https://togithub.com/charliermarsh/ruff/pull/1702)
- Remove `add_check` methods by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1705](https://togithub.com/charliermarsh/ruff/pull/1705)
- Use `trim_end` when checking line continutation by
[@&#8203;harupy](https://togithub.com/harupy) in
[https://github.com/charliermarsh/ruff/pull/1706](https://togithub.com/charliermarsh/ruff/pull/1706)
- Automatically remove unused variables by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1683](https://togithub.com/charliermarsh/ruff/pull/1683)
- Lazily compute ranges for class and function bindings by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1708](https://togithub.com/charliermarsh/ruff/pull/1708)
- Add more backticks to flake8-pytest-style error messages by
[@&#8203;harupy](https://togithub.com/harupy) in
[https://github.com/charliermarsh/ruff/pull/1707](https://togithub.com/charliermarsh/ruff/pull/1707)
- Increase blackd wait time by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1709](https://togithub.com/charliermarsh/ruff/pull/1709)
- Revert "Include list of fixed files in `stderr` output
([#&#8203;1701](https://togithub.com/charliermarsh/ruff/issues/1701))"
by [@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1711](https://togithub.com/charliermarsh/ruff/pull/1711)

**Full Changelog**:
astral-sh/ruff@v0.0.212...v0.0.213

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuODQuMiJ9-->

Signed-off-by: Renovate Bot <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Contributor

ashb commented Jan 7, 2023

Is there any way I can drive this by an env var?

My setup is I have a poetry run ruff in my .pre-commit.yaml file. and it would be nice if I could set something like RUFF_FORMAT=github or similar to choose the mode. Is this possible? (I couldn't see something like in the docs or a quick skim of the code)

Member Author

charliermarsh commented Jan 7, 2023

It's not supported right now, but I agree that it'd be a useful thing to respect an env var here for that reason. Will add.

charliermarsh mentioned this pull request

Allow Ruff's format to be overridden by an environment variable #1716

Closed

edgarrmondragon mentioned this pull request

Automatically enable --format=github if the environment looks like GitHub Actions? #1973

Closed

edgarrmondragon mentioned this pull request

Feature Request: GitHub Action for Ruff #3289

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet