[red-knot] Add more tests for * imports
#16955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
testing
carljm
approved these changes
Mar 24, 2025
|
AlexWaygood
force-pushed
the
alex/more-star-import-tests
branch
from
e0ffb35 to
28b7d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates out the entirely new tests from #16923 into a standalone PR. I'll rebase #16923 on top of this branch.
The reasons for separating it out are:
*imports #16923 exactly how the functionality is changing (we can see the assertions in the tests change, which isn't so obvious if the tests are entirely new)*imports #16923 is getting pretty big; this should reduce the diff on that PR somewhat*imports #16923 for whatever reason, it'll be nice to keep the testsTest Plan
cargo test -p red_knot_python_semantic