Skip to content

Update replacement paths for AIR302 #16876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Update replacement paths for AIR302 #16876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions crates/ruff_linter/src/rules/airflow/rules/removal_in_3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,25 +613,18 @@ fn check_name(checker: &Checker, expr: &Expr, range: TextRange) {
}

// airflow.datasets
["airflow", "Dataset"] => Replacement::Name("airflow.sdk.definitions.asset.Asset"),
["airflow", "datasets", "DatasetAliasEvent"] => Replacement::None,
["airflow", "datasets", "Dataset"] => {
Replacement::Name("airflow.sdk.definitions.asset.Asset")
}
["airflow", "datasets", "DatasetAlias"] => {
Replacement::Name("airflow.sdk.definitions.asset.AssetAlias")
}
["airflow", "datasets", "DatasetAll"] => {
Replacement::Name("airflow.sdk.definitions.asset.AssetAll")
}
["airflow", "datasets", "DatasetAny"] => {
Replacement::Name("airflow.sdk.definitions.asset.AssetAny")
["airflow", "Dataset"] | ["airflow", "datasets", "Dataset"] => {
Replacement::Name("airflow.sdk.Asset")
}
["airflow", "datasets", "DatasetAliasEvent"] => Replacement::None,
["airflow", "datasets", "DatasetAlias"] => Replacement::Name("airflow.sdk.AssetAlias"),
["airflow", "datasets", "DatasetAll"] => Replacement::Name("airflow.sdk.AssetAll"),
["airflow", "datasets", "DatasetAny"] => Replacement::Name("airflow.sdk.AssetAny"),
["airflow", "datasets", "expand_alias_to_datasets"] => {
Replacement::Name("airflow.sdk.definitions.asset.expand_alias_to_assets")
Replacement::Name("airflow.sdk.expand_alias_to_assets")
}
["airflow", "datasets", "metadata", "Metadata"] => {
Replacement::Name("airflow.sdk.definitions.asset.metadata.Metadata")
Replacement::Name("airflow.sdk.Metadata")
}

// airflow.datasets.manager
Expand Down
9 changes: 4 additions & 5 deletions ...rflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_class_attribute.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: crates/ruff_linter/src/rules/airflow/mod.rs
snapshot_kind: text
---
AIR302_class_attribute.py:24:21: AIR302 `airflow.Dataset` is removed in Airflow 3.0
|
Expand All @@ -10,7 +9,7 @@ AIR302_class_attribute.py:24:21: AIR302 `airflow.Dataset` is removed in Airflow
25 | dataset_from_root.iter_datasets()
26 | dataset_from_root.iter_dataset_aliases()
|
= help: Use `airflow.sdk.definitions.asset.Asset` instead
= help: Use `airflow.sdk.Asset` instead

AIR302_class_attribute.py:25:19: AIR302 `iter_datasets` is removed in Airflow 3.0
|
Expand Down Expand Up @@ -41,7 +40,7 @@ AIR302_class_attribute.py:29:31: AIR302 `airflow.datasets.Dataset` is removed in
30 | dataset_to_test_method_call.iter_datasets()
31 | dataset_to_test_method_call.iter_dataset_aliases()
|
= help: Use `airflow.sdk.definitions.asset.Asset` instead
= help: Use `airflow.sdk.Asset` instead

AIR302_class_attribute.py:30:29: AIR302 `iter_datasets` is removed in Airflow 3.0
|
Expand Down Expand Up @@ -73,7 +72,7 @@ AIR302_class_attribute.py:33:29: AIR302 `airflow.datasets.DatasetAlias` is remov
34 | alias_to_test_method_call.iter_datasets()
35 | alias_to_test_method_call.iter_dataset_aliases()
|
= help: Use `airflow.sdk.definitions.asset.AssetAlias` instead
= help: Use `airflow.sdk.AssetAlias` instead

AIR302_class_attribute.py:34:27: AIR302 `iter_datasets` is removed in Airflow 3.0
|
Expand Down Expand Up @@ -104,7 +103,7 @@ AIR302_class_attribute.py:37:27: AIR302 `airflow.datasets.DatasetAny` is removed
38 | any_to_test_method_call.iter_datasets()
39 | any_to_test_method_call.iter_dataset_aliases()
|
= help: Use `airflow.sdk.definitions.asset.AssetAny` instead
= help: Use `airflow.sdk.AssetAny` instead

AIR302_class_attribute.py:38:25: AIR302 `iter_datasets` is removed in Airflow 3.0
|
Expand Down
15 changes: 7 additions & 8 deletions ...c/rules/airflow/snapshots/ruff_linter__rules__airflow__tests__AIR302_AIR302_names.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: crates/ruff_linter/src/rules/airflow/mod.rs
assertion_line: 29
---
AIR302_names.py:107:1: AIR302 `airflow.PY36` is removed in Airflow 3.0
|
Expand Down Expand Up @@ -74,7 +73,7 @@ AIR302_names.py:108:1: AIR302 `airflow.Dataset` is removed in Airflow 3.0
109 |
110 | # airflow.api_connexion.security
|
= help: Use `airflow.sdk.definitions.asset.Asset` instead
= help: Use `airflow.sdk.Asset` instead

AIR302_names.py:111:1: AIR302 `airflow.api_connexion.security.requires_access` is removed in Airflow 3.0
|
Expand Down Expand Up @@ -197,7 +196,7 @@ AIR302_names.py:125:1: AIR302 `airflow.datasets.Dataset` is removed in Airflow 3
126 | DatasetAlias()
127 | DatasetAliasEvent()
|
= help: Use `airflow.sdk.definitions.asset.Asset` instead
= help: Use `airflow.sdk.Asset` instead

AIR302_names.py:126:1: AIR302 `airflow.datasets.DatasetAlias` is removed in Airflow 3.0
|
Expand All @@ -208,7 +207,7 @@ AIR302_names.py:126:1: AIR302 `airflow.datasets.DatasetAlias` is removed in Airf
127 | DatasetAliasEvent()
128 | DatasetAll()
|
= help: Use `airflow.sdk.definitions.asset.AssetAlias` instead
= help: Use `airflow.sdk.AssetAlias` instead

AIR302_names.py:127:1: AIR302 `airflow.datasets.DatasetAliasEvent` is removed in Airflow 3.0
|
Expand All @@ -229,7 +228,7 @@ AIR302_names.py:128:1: AIR302 `airflow.datasets.DatasetAll` is removed in Airflo
129 | DatasetAny()
130 | Metadata()
|
= help: Use `airflow.sdk.definitions.asset.AssetAll` instead
= help: Use `airflow.sdk.AssetAll` instead

AIR302_names.py:129:1: AIR302 `airflow.datasets.DatasetAny` is removed in Airflow 3.0
|
Expand All @@ -240,7 +239,7 @@ AIR302_names.py:129:1: AIR302 `airflow.datasets.DatasetAny` is removed in Airflo
130 | Metadata()
131 | expand_alias_to_datasets
|
= help: Use `airflow.sdk.definitions.asset.AssetAny` instead
= help: Use `airflow.sdk.AssetAny` instead

AIR302_names.py:130:1: AIR302 `airflow.datasets.metadata.Metadata` is removed in Airflow 3.0
|
Expand All @@ -250,7 +249,7 @@ AIR302_names.py:130:1: AIR302 `airflow.datasets.metadata.Metadata` is removed in
| ^^^^^^^^ AIR302
131 | expand_alias_to_datasets
|
= help: Use `airflow.sdk.definitions.asset.metadata.Metadata` instead
= help: Use `airflow.sdk.Metadata` instead

AIR302_names.py:131:1: AIR302 `airflow.datasets.expand_alias_to_datasets` is removed in Airflow 3.0
|
Expand All @@ -261,7 +260,7 @@ AIR302_names.py:131:1: AIR302 `airflow.datasets.expand_alias_to_datasets` is rem
132 |
133 | # airflow.datasets.manager
|
= help: Use `airflow.sdk.definitions.asset.expand_alias_to_assets` instead
= help: Use `airflow.sdk.expand_alias_to_assets` instead

AIR302_names.py:135:1: AIR302 `airflow.datasets.manager.dataset_manager` is removed in Airflow 3.0
|
Expand Down
Loading