-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[pygrep-hooks
]: Detect file-level suppressions comments without rule codes (PGH004
)
#16699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #16699 will degrade performances by 4.6%Comparing Summary
Benchmarks breakdown
|
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
PGH004 | 5 | 5 | 0 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
…e codes (`PGH004`)
1e89b3d
to
c1c0d1b
Compare
The ecosystem checks are all true-positives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I do think that we should have a followup issue/PR where we add the feature that this rule has for inline suppressions where it tries to guess if you just forgot a colon
Summary
This PR stabilizes the preview behavior of
PGH004
to also detect blanked file-level noqa comments (and not just line level comments).This preview behavior was first released with Ruff 0.4.8 (June 2025). There are no open issues or PRs open related to this behavior.