Use inline snapshots in # noqa unit tests
#16687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(It was painful switching back and forth to find the corresponding snapshot files.) |
CodSpeed Performance ReportMerging #16687 will degrade performances by 4.6%Comparing Summary
Benchmarks breakdown
|
|
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
## Summary Follow-up to #16677. This change converts all unit tests (69 of them) in `noqa.rs` to use inline snapshots instead. It extends the file by more than 1000 lines, but the tests are now much easier to read and reason about. ## Test Plan `cargo insta test`.
MichaReiser
pushed a commit
that referenced
this pull request
Mar 13, 2025
## Summary Follow-up to #16677. This change converts all unit tests (69 of them) in `noqa.rs` to use inline snapshots instead. It extends the file by more than 1000 lines, but the tests are now much easier to read and reason about. ## Test Plan `cargo insta test`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #16677.
This change converts all unit tests (69 of them) in
noqa.rsto use inline snapshots instead. It extends the file by more than 1000 lines, but the tests are now much easier to read and reason about.Test Plan
cargo insta test.