Assert that formatted code doesn't introduce any new unsupported syntax errors #16549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
internal
MichaReiser
commented
Mar 7, 2025
Comment on lines
+547
to
+556
| match collected.entry(error_fingerprint) { | ||
| Entry::Occupied(_) => { | ||
| error_fingerprint = | ||
| fingerprint_unsupported_syntax_error(error, error_fingerprint); | ||
| } | ||
| Entry::Vacant(entry) => { | ||
| entry.insert(error.clone()); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is inspired by our gitlab reporter that uses the very same approach for lint errors.
|
MichaReiser
deleted the
micha/assert-unsupported-syntax-errors-in-formatter-tests
branch
|
Looks great, thanks for pinging me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should give us better coverage for the unsupported syntax error features and
increases our confidence that the formatter doesn't accidentially introduce new unsupported
syntax errors.
A feature like this would have been very useful when working on f-string formatting
where it took a lot of iteration to find all Python 3.11 or older incompatibilities.
Test Plan
I applied my changes on top of #16523 and
removed the target version check in the with-statement formatting code. As expected,
the integration tests now failed