Skip to content

CI: Treat mdtest Markdown files as code #14653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

sharkdp
Copy link
Contributor

@sharkdp sharkdp commented Nov 28, 2024

Summary

Make sure we run the tests for mdtest-only changes.

Test Plan

Tested if positive glob patterns override negative patterns here: https://codepen.io/mrmlnc/pen/OXQjMe

Will test using the changes in #14652 (where tests were previously skipped)

@sharkdp sharkdp added the internal An internal refactor or improvement label Nov 28, 2024
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works. Is it worth pushing a temporary commit to an md file here to make sure it triggers CI, and then reverting it again afterwards?

@AlexWaygood
Copy link
Member

Oh I guess CI will always be triggered here anyway, because this PR edits the workflow file. So the temporary commit would also have to remove the line in this workflow file that means that CI is triggered if the workflow file itself is edited in a PR

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@sharkdp
Copy link
Contributor Author

sharkdp commented Nov 28, 2024

I would have to be careful to remove .github/workflows/ci.yml everywhere and add a new !.github/workflows/ci.yml pattern in the code section. And then I might still miss something and we still don't know if CI ran because of the mdtest change or for some other reason.

If it's okay, I would just merge this and then rebase #14652 to test it properly?

@AlexWaygood
Copy link
Member

Sounds good!

@sharkdp sharkdp merged commit 8639f8c into main Nov 28, 2024
21 checks passed
@sharkdp sharkdp deleted the david/run-ci-for-mdtest-changes branch November 28, 2024 09:04
@sharkdp
Copy link
Contributor Author

sharkdp commented Nov 28, 2024

Seems to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants