Skip to content

Add trigger policy #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

Annopaolo
Copy link
Collaborator

No description provided.

@Annopaolo Annopaolo marked this pull request as draft April 8, 2021 16:07
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #45 (ef3f09e) into master (4a321a2) will not change coverage.
The diff coverage is n/a.

❗ Current head ef3f09e differs from pull request most recent head 6ba13cd. Consider uploading reports for the commit 6ba13cd to get more accurate results

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   64.22%   64.22%           
=======================================
  Files           4        4           
  Lines         123      123           
=======================================
  Hits           79       79           
  Misses         44       44           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Annopaolo Annopaolo force-pushed the trigger_policy_protobuf branch from 8c1ae7c to 607d27e Compare April 9, 2021 13:37
@Annopaolo Annopaolo changed the base branch from release-1.0 to master April 9, 2021 13:37
@Annopaolo Annopaolo marked this pull request as ready for review April 14, 2021 08:31
Copy link
Contributor

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, did you check it with protoc?

@Annopaolo
Copy link
Collaborator Author

Looks fine, did you check it with protoc?

I did, just to be sure. However, it seems to me that exprotobuf won't load the struct definition if the .proto file is incorrect.

@Annopaolo Annopaolo force-pushed the trigger_policy_protobuf branch from 607d27e to 48d781d Compare April 29, 2021 10:53
@Annopaolo Annopaolo force-pushed the trigger_policy_protobuf branch from 48d781d to 412be1b Compare May 31, 2021 13:23
@Annopaolo Annopaolo force-pushed the trigger_policy_protobuf branch from 412be1b to a6cfc36 Compare September 21, 2022 08:40
@Annopaolo Annopaolo force-pushed the trigger_policy_protobuf branch from a6cfc36 to 9007eb8 Compare September 30, 2022 16:26
Add protobufs for trigger policy RPCs

Signed-off-by: Arnaldo Cesco <[email protected]>
@rbino rbino merged commit 3afd4f6 into astarte-platform:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants