Move Introspection triggers into Device triggers #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introspection triggers are currently unused. Move them in the device logic to start keeping track of introspection changes. Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
added
the
API
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 84.12% 84.34% +0.22%
==========================================
Files 21 21
Lines 485 511 +26
==========================================
+ Hits 408 431 +23
- Misses 77 80 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Annopaolo
added a commit
to Annopaolo/astarte
that referenced
this pull request
Sep 6, 2022
Since introspection triggers are now device triggers, reflect this change in related funcitons. See astarte-platform/astarte_core#76. Signed-off-by: Arnaldo Cesco <[email protected]>
Annopaolo
added a commit
to Annopaolo/astarte
that referenced
this pull request
Sep 6, 2022
Since introspection triggers are now device triggers, reflect this change in related funcitons. See astarte-platform/astarte_core#76. Signed-off-by: Arnaldo Cesco <[email protected]>
Pavinati
approved these changes
Sep 12, 2022
Annopaolo
force-pushed
the
introspection-triggers-to-device
branch
from
60412a1 to
ad05506
Compare
rbino
requested changes
Sep 20, 2022
Reconcile the introspection (device) triggers API with the one exposed by data triggers,
e.g. use the same name for equivalent fields, and allow either {interface_name, interface_major}
or any interface as match condition for interface added/removed/updated triggers.
Annopaolo
force-pushed
the
introspection-triggers-to-device
branch
from
ad05506 to
2e1e092
Compare
rbino
approved these changes
Sep 21, 2022
bettio
approved these changes
Sep 21, 2022
Annopaolo
added a commit
to Annopaolo/astarte
that referenced
this pull request
Sep 22, 2022
Since introspection triggers are now device triggers, reflect this change in related funcitons. See astarte-platform/astarte_core#76. Signed-off-by: Arnaldo Cesco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introspection triggers are currently unused. In order to start keeping track of introspection changes, group them with the related device triggers. To be consistent with other triggers, make naming uniform (e.g. replace the
match_interfacefield with the pair{interface_name, interface_major}).