feat: json encoder for incoming introspection #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astarte-platform#77 added introspection_map to incoming introspection event, but its jason encoder was never implemented. this was handled in trigger engine with an ad-hoc "encoder", which did not respect other encoders format, and eg was missing the `type` field in the json properly implementing its encoder results in the removal of said custom code Signed-off-by: Francesco Noacco <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.2 #121 +/- ##
===============================================
+ Coverage 76.53% 76.64% +0.10%
===============================================
Files 50 50
Lines 861 865 +4
===============================================
+ Hits 659 663 +4
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Annopaolo
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77 added introspection_map to incoming introspection event, but its jason encoder was never implemented.
this was handled in trigger engine with an ad-hoc "encoder", which did not respect other encoders format, and eg was missing the
typefield in the jsonproperly implementing its encoder results in the removal of said custom code