Skip to content

chore: define type t for all custom types #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

noaccOS
Copy link
Contributor

@noaccOS noaccOS commented Feb 18, 2025

use typedstruct and typed_ecto_schema for structs and schemas respectively, manually define t for Ecto.Types

This is needed for astarte-platform/astarte_data_access#71 to successfully run dialyzer

@noaccOS noaccOS force-pushed the chore/type-t branch 2 times, most recently from 2ab8be6 to 8c0f519 Compare February 18, 2025 15:28
@noaccOS noaccOS changed the base branch from master to release-1.2 February 18, 2025 15:30
use typedstruct and typed_ecto_schema for
structs and schemas respectively, manually define `t` for `Ecto.Type`s

Signed-off-by: Francesco Noacco <[email protected]>
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (0386df0) to head (0a6024c).
Report is 2 commits behind head on release-1.2.

Files with missing lines Patch % Lines
lib/astarte_core/interface_descriptor.ex 0.00% 1 Missing ⚠️
lib/astarte_core/triggers/data_trigger.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.2     #116   +/-   ##
============================================
  Coverage        76.53%   76.53%           
============================================
  Files               50       50           
  Lines              861      861           
============================================
  Hits               659      659           
  Misses             202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Annopaolo Annopaolo merged commit 7ba3d8f into astarte-platform:release-1.2 Mar 13, 2025
3 checks passed
@noaccOS noaccOS deleted the chore/type-t branch March 13, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants