"dnu restore" does not fail when a dependency does not support the target framework

[rowanmiller]

For example, the following project.json says it targets .NET 4.5 and K10 but the EntityFramework.Relational package only supports .NET 4.5.1 (not 4.5). There are no errors during package restore, you just get build errors when you try to build because there is no reference to EntityFramework.Relational.

{
  "version": "1.0.0-*",
  "dependencies": {
    "EntityFramework.Relational": "7.0.0-*"
  },
  "frameworks": {
    "net45": {},
    "k10": {}
  }
}

BTW, by comparison here is the message generated from NuGet for non-K projects:

Install-Package : Could not install package 'EntityFramework.Relational 7.0.0-alpha3-10425'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.5', but the package does not 
contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

[davidfowl]

Yep this bug is a dupe of #290 but I like your explanation better.

[davidfowl]

IMO, restore should never fail but there should be a runtime exception and something should show up in VS.

[rowanmiller]

I'm not so sure, in my mind restore is about making sure we have all the dependencies for the project. We know at the time of restore that we can't meet the dependency requirements so an error would make sense to me. Or perhaps a warning since there may be other targets that will run.
That said, I don't care that much and if we throw something that is clear at a later point that works too 😄