dnu pack fails when project.json is readonly.

[phenning]

When running dnu pack on a project where the project.json is a read-only file, the following exception and callstack is generated. This impacts SCC (TFS) scenarios where the project.json is not checked out.

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : System.UnauthorizedAccessException: Access to the path 'c:\users\phenning\documents\visual studio 2015\Projects\artifacts\bin\ConsoleApp6\Debug\app\project.json' is denied.

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at System.IO.File.WriteAllText(String path, String contents)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.InstallBuilder.ModifyJson(String jsonFile, Action`1 modifier)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.InstallBuilder.WriteApplicationProjectJsonFile(String applicationFolder)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.InstallBuilder.BuildApplicationFiles(String baseOutputPath)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.InstallBuilder.Build(String outputPath)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.BuildManager.Build()

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.Program.<>c__DisplayClass3_3.<Main>b__6()

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.Runtime.Common.CommandLine.CommandLineApplication.Execute(String[] args)

1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\DNX\Microsoft.DNX.targets(134,5): error : at Microsoft.Framework.PackageManager.Program.Main(String[] args)

[davidfowl]

/cc @muratg @victorhurdugaci

@victorhurdugaci Why is the InstallBuilder doing anything with the project.json here?

[muratg]

@victorhurdugaci , can you have a look?

[davidfowl]

This is a simple fix. a One liner actually.

[davidfowl]

I can fix it if @victorhurdugaci is working on something else. I'd suggest waiting on @troydai's change though.

[victorhurdugaci]

I can fix it too, I have time for this :)

[davidfowl]

Great!

[davidfowl]

dnx/src/Microsoft.Framework.Runtime/DependencyManagement/LockFileReader.cs

Line 21 in f0a852a

using (var stream = new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.Read))

File.OpenRead should fix it.

[davidfowl]

That file moved into the package manager and there should be a new one from @troydai 's change in the runtime