Skip to content

Try to fix C++ example #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Sep 26, 2024

The first example has two issues.

  1. There is a compilation error on std::hash due to wrong usage.
  2. \w is not a valid escape sequence. Does it mean \v?

This PR try to fix these.

By the way, there seem to be several other problems with the C++ examples.
Can I submit a PR or issue for these as well?
Or do you plan to change them drastically in the future?

@ashvardanian ashvardanian merged commit 94bb5d6 into ashvardanian:main Sep 26, 2024
@ashvardanian
Copy link
Owner

Thank you, @toge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants