Skip to content

chore: add tests for relationship pagination #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

rbino
Copy link
Contributor

@rbino rbino commented May 3, 2024

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@rbino rbino force-pushed the relationship-pagination branch 2 times, most recently from 528d3dd to 7523957 Compare May 4, 2024 11:44
@rbino rbino marked this pull request as ready for review May 4, 2024 13:24
@rbino rbino requested a review from zachdaniel May 16, 2024 19:26
@rbino rbino force-pushed the relationship-pagination branch from 7523957 to 1d2a95d Compare May 16, 2024 19:28
@zachdaniel
Copy link
Contributor

looks like migrations need to be generated, and also potentially some credo things?

@rbino
Copy link
Contributor Author

rbino commented May 16, 2024

Yeah I think it broke some things after the rebase, fixing it

@rbino rbino force-pushed the relationship-pagination branch 2 times, most recently from 53a4ce2 to 483f877 Compare May 16, 2024 21:22
@rbino rbino force-pushed the relationship-pagination branch from 483f877 to 6aeb1d7 Compare May 16, 2024 21:23
@rbino rbino requested review from zachdaniel and removed request for zachdaniel May 16, 2024 22:15
@zachdaniel zachdaniel merged commit ad0b1a5 into ash-project:main May 16, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants