Skip to content

Remove unused gradle properties & migrate tests to Junit5 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jan 20, 2022

Pure boring maintenance:

  • Removed unused properties in gradle
  • Migrated test to Junit5
  • Refactor tests to improve readability (opinionated 😅 )

@abelsromero
Copy link
Member Author

Btw, I removed the delete of outputs from tests since all tests generate outputs in build. Doesn't seem to add much with the scope of the project (not like we generate teras of data).

@robertpanzer
Copy link
Member

Thank you! That's great!

@robertpanzer robertpanzer merged commit cd58160 into asciidoctor:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants