Generate stable test output #31
Conversation
|
Additional fixes to avoid depending on version numbers for the expected output:
-<div class="content"><!-- Generator: GNU source-highlight 3.1.7
+<div class="content"><!-- Generator: GNU source-highlight
-<meta name="generator" content="AsciiDoc 8.6.9">
+<meta name="generator" content="AsciiDoc test-0.1.1"> |
| _frozentime = 0X3DE170D6 | ||
| _frozentz = 'Pacific/Auckland' | ||
|
|
||
| def _fake_localtime(t=_frozentime + 1): |
There was a problem hiding this comment.
could be named _frozen_localtime instead of _fake_localtime to be consistent.
|
+1 What about your comments? Are you still working on this PR or should we merge it? Cheers, |
|
I think I will apply the 2 suggestions I've proposed in comments : re-reading them after some days, I am +1 with myself 😄 Then this PR is ready for merging, and I could work to finish #30. |
|
Hi, For the Last updated field, you could also use the footer-style attribute to none as default in the tests. This would remove the last updated field in the html pages for the tests. Joseph |
| @@ -58,7 +58,7 @@ endif::basebackend-docbook[] | |||
| ifdef::basebackend-html[] | |||
| [source-filter-style] | |||
| ifeval::["{source-highlighter}"=="source-highlight"] | |||
| source-style=template="source-highlight-block",presubs=(),postsubs=("callouts",),posattrs=("style","language","src_numbered","src_tab"),filter="source-highlight -f xhtml -s {language} {src_numbered?--line-number=' '} {src_tab?--tab={src_tab}} {args=}" | |||
| source-style=template="source-highlight-block",presubs=(),postsubs=("callouts",),posattrs=("style","language","src_numbered","src_tab"),filter="source-highlight --gen-version -f xhtml -s {language} {src_numbered?--line-number=' '} {src_tab?--tab={src_tab}} {args=}" | |||
| endif::[] | |||
There was a problem hiding this comment.
why does adding the generated version help to produce stable output?
There was a problem hiding this comment.
actually the switch --gen-version toggle off the version number
There was a problem hiding this comment.
Ok, makes sense (well your change does, the option doesn't, should be --no-gen-version).
|
Are you able to squash the commits correcting previous commits? Leaving 4 commits. |
|
ok, I'll try to rewrite the history |
|
I've rebased and merged the commits. |
Generate stable test output
Currently the output of the tests is not stable when running in different environments:
Last updatedtimestamp is printed in the output of many testsThis PR removes the above glitches. It is a prerequisite for fixing issue #30
Details of the changes:
time.localtimefunction and theTZenvironment variable which are used to generate theLast updatedtimestampbarchart.pyfile to avoid printing an error message with the absolute path of the missing file{docfile}with relative path{docname}.txt