-
-
Notifications
You must be signed in to change notification settings - Fork 128
Conversation
+1 looks good to me. Thanks a lot! This PR will be very valuable, in particular it will allow us to check future pull requests automatically. We just need to enable the Travis hook in the projects settings after the PR has been merged. Cheers, |
Just one question. The log file of the 2.6 build contains several error messages (related to syntax errors) but it does not fail. Is this supposed to happen? |
Hello Michel, I noticed these errors and other limitations as well. I did further research about these warnings, and I found that the test suite is a bit too indulgent:
I've started to address all these points in a separate branch Then I discovered a last limitation: doing I see 2 solutions so far:
I will open a separate issue for it. |
This is the current state for the |
@@ -255,3 +255,6 @@ def execute(self, infile, outfile=None, backend=None): | |||
import doctest | |||
options = doctest.NORMALIZE_WHITESPACE + doctest.ELLIPSIS | |||
doctest.testmod(optionflags=options) | |||
test_result = doctest.testmod(optionflags=options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are calling doctest.testmod() twice here. Is this intended? If so, why?
Michel
I like this PR and we can merge it. I just have a very minor comment (see my previous inline comment). Cheers, |
I've updated the patch, thank you for your review |
Add support for Travis-CI integration
@michel-kraemer have you set up a travis account and the asciidoc github repository so that travis will work? http://docs.travis-ci.com/user/getting-started/ |
I'm on it... |
Ok, I was just gonna say it would be appropriate to add a status icon to the readme (although only if its green ;-) |
Great 👍 |
OK. Seems to work: I just added the status icon to the README file. Cheers, |
It gives basic support for continuous integration.
This is tested, and the build passes: https://travis-ci.org/florentx/asciidoc/builds/24401205