Add callback functionality for vertex insertation, triangle add/change #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cas C++ 11 is not available, its disabled
|
Hi Artem, |
Unfortunately, I have no spare time now. Life keeps me busy elsewhere. I will take a look as soon as I can, but cannot promise quick response. |
Closed
| @@ -31,6 +31,10 @@ option(CDT_USE_STRONG_TYPING | |||
| "If enabled uses strong typing for types: useful for development and debugging" | |||
| OFF) | |||
|
|
|||
| option(CDT_CALLBACK_DISABLED | |||
| "If enabled a callbeack function can be registered if a triabngle is created or changed (>=C++11 necessary)" | |||
| // C++11 required for std::fucntion callbacks | ||
| #ifndef CDT_CALLBACK_DISABLED | ||
| std::function<void(TriInd, CallbackType)> callback_tri; // callback function for triangle creation | ||
| std::function<void(VertInd, CallbackType)> callback_vertex; // callback function for vertex insertation |
There was a problem hiding this comment.
It seems Triangulation class members follow m_memberName naming style.
Naming style of callback_tri and callback_vertex makes members names inconsistent.
artem-ogre
reviewed
May 9, 2025
| @@ -1093,6 +1099,12 @@ void Triangulation<T, TNearPointLocator>::insertVertex(const VertInd iVert) | |||
| const VertInd walkStart = m_nearPtLocator.nearPoint(v, vertices); | |||
| insertVertex(iVert, walkStart); | |||
There was a problem hiding this comment.
This will also call insert-vertex callback, so the callback will be called twice. Is it intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case C++ 11 is not available, its disabled