Enable Kover for serialization, disable for Optics KSP #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
nomisRev
reviewed
Nov 5, 2023
| @@ -68,10 +68,11 @@ dependencies { | |||
| kover(projects.arrowContinuations) | |||
| kover(projects.arrowCore) | |||
| kover(projects.arrowCoreRetrofit) | |||
| // kover(projects.arrowCoreSerialization) | |||
There was a problem hiding this comment.
I tried to add it for completeness, but it turns out that it causes problems with Kover (as the Optics KSP does). At the end I’ll remove both, and add a warning in the code to remember this.
| kover(projects.arrowFxCoroutines) | ||
| kover(projects.arrowFxStm) | ||
| kover(projects.arrowOptics) | ||
| kover(projects.arrowOpticsKspPlugin) | ||
| // kover(projects.arrowOpticsKspPlugin) |
There was a problem hiding this comment.
I think this can be removed instead of comment?
Suggested change
| // kover(projects.arrowOpticsKspPlugin) |
There was a problem hiding this comment.
I’d rather keep it alongside the comment in the corresponding section
nomisRev
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kover report is causing problems with the new version of KSP