Skip to content

Update Arrow-Atomic #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Update Arrow-Atomic #3225

merged 9 commits into from
Oct 24, 2023

Conversation

nomisRev
Copy link
Member

Closes #3144, #3145, #3146, #3147.

Also replaces any usage of Atomic with Int to AtomicInt.

@serras
Copy link
Member

serras commented Oct 24, 2023

Let's get this one and #3224 merged first, since they are more or less self-contained.

Then my plan is to push a change that adds kotlin.test to every library test source set, so that we don't have 10000 different ways of adding the library. WDYT?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Kover Report

File Coverage [14.29%]
arrow-libs/fx/arrow-fx-coroutines/src/commonTest/kotlin/arrow/fx/coroutines/Platform.kt 14.29%
Total Project Coverage 54.19%

@serras
Copy link
Member

serras commented Oct 24, 2023

After quite some investigation, it seems that runTest doesn't work exactly as runBlocking in Native. But on the other hand runBlocking is not available in JS... So I ended up doing a "run one in Native and the other in the rest".

It seems everything works alright if the "skip delays" is disabled.

@serras serras merged commit a65a833 into main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor AtomicBooleanTest from Kotest Plugin to Kotlin-test runtime
2 participants