[WIP] selective functor #1335
Merged
[WIP] selective functor #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-gibson
force-pushed
the
rg_selective_functor
branch
from
ffa8b37 to
2670b77
Compare
richard-gibson
force-pushed
the
rg_selective_functor
branch
from
2670b77 to
c005f00
Compare
pakoito
reviewed
Mar 8, 2019
| @@ -49,7 +50,8 @@ class OptionTest : UnitSpec() { | |||
| TraverseFilterLaws.laws(Option.traverseFilter(), Option.applicative(), ::Some, Eq.any()), | |||
| MonadFilterLaws.laws(Option.monadFilter(), ::Some, Eq.any()), | |||
| HashLaws.laws(Option.hash(Int.hash()), Option.eq(Int.eq())) { it.some() }, | |||
| SemigroupalLaws.laws(Option.semigroupal(), ::Some, ::bijection, associativeSemigroupalEq) | |||
| SemigroupalLaws.laws(Option.semigroupal(), ::Some, ::bijection, associativeSemigroupalEq), | |||
| SelectiveLaws.laws(Option.selective(), Eq.any()) | |||
There was a problem hiding this comment.
This is not necessary as MonadFilterLaws already check SelectiveLaws. Same for the others.
There was a problem hiding this comment.
Cool, will remove. In that case I should remove all selective instances if there is a monad instance available too
pakoito
reviewed
Mar 8, 2019
| @extension | ||
| interface Function0Selective : Selective<ForFunction0>, Function0Applicative { | ||
| override fun <A, B> Function0Of<Either<A, B>>.select(f: Kind<ForFunction0, (A) -> B>): Kind<ForFunction0, B> = | ||
| fix().flatMap { it.fold({l -> just(l).ap(f)}, {r -> just(identity(r))})} |
There was a problem hiding this comment.
Typo: additional whitespace. Format it with IntelliJ.
pakoito
reviewed
Mar 8, 2019
|
|
||
| fun <F> laws(A: Selective<F>, EQ: Eq<Kind<F, Int>>): List<Law> = | ||
| ApplicativeLaws.laws(A, EQ) + listOf( | ||
| Law("Selective Laws: identity") { A.identityLaw(EQ) }, |
There was a problem hiding this comment.
Did they have more descriptive names on the paper?
There was a problem hiding this comment.
Distributivity, Associativity, selectM == select if a Monad.
I can add.
pakoito
reviewed
Mar 8, 2019
| @extension | ||
| interface OptionSelective : Selective<ForOption>, OptionApplicative { | ||
| override fun <A, B> OptionOf<Either<A, B>>.select(f: OptionOf<(A) -> B>): Option<B> = | ||
| fix().flatMap { it.fold({l -> just(l).ap(f)}, {r -> just(identity(r))})} |
pakoito
approved these changes
Mar 8, 2019
raulraja
approved these changes
Mar 8, 2019
Run |
richard-gibson
force-pushed
the
rg_selective_functor
branch
from
c005f00 to
d12e819
Compare
richard-gibson
force-pushed
the
rg_selective_functor
branch
from
d5e6c0f to
251b487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1329
continuing with unfinished tasks, feedback appreciated
Interface definition
Update Monad
Laws
Instances
Tests
Documentation