Docs styles tweaks #1264
Merged
Docs styles tweaks #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
requested review from
raulraja,
pakoito,
israelperezglez and
JorgeCastilloPrz
raulraja
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings together some different improvements in the website look and feel, especially on mobile viewports:
Increment vertical rhythm on the code snippets typography to improve readability (as suggested by @pakoito here Specify z-index for code snippets to avoid them clashing with sidebar #1051 (comment)).
Increase sidebar z-index to avoid clashes wit document elements (e.g video buttons)
Refactor the sidebar behaviour to improve readility on mobile viewports, by streamlining the code and defining better the different cases.
Show icons in the nav menu when on mobile viewports, as after the inclusion of a fourth item, nav menu items were a bit misplaced.
Removes Hammer logic, as touch gestures are no longer necessary.
Update sidebar menu entries location in the docs docs for the new one.
Previews:
This closes #1052