Docs contributions section revamp #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ip-797-blogs-presentations
israelperezglez
approved these changes
Jan 22, 2019
raulraja
requested changes
Jan 22, 2019
| @@ -1,10 +1,3 @@ | |||
| defaults: | |||
| - | |||
There was a problem hiding this comment.
removing this breaks the api docs
There was a problem hiding this comment.
Indeed, will fix it in the next commit too, thanks for noticing it 👍
| @@ -0,0 +1,316 @@ | |||
| options: | |||
There was a problem hiding this comment.
Yep, didn't actually update the menu items, my bad 🤦
|
Looks great but I'm missing content |
raulraja
approved these changes
Jan 23, 2019
|
Awesome! thanks and outstanding work, can't wait to see this live! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revamp the media/contributions section giving it a more concise style:
The clipped title and the bad setting of the Gitter button are due to the capturing technique, don't worry about them
This closes #626
This closes #797