Fix IOFrame usage in IOBracket #1258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOFrame
was not correctly called unless manually wrapped inIO.Bind
. It did not run usingflatMap
like Cats-effect'sIO
becauseIO.RaiseError
is overridden to short-circuitflatMap
like thisoverride fun <B> flatMap(f: (Nothing) -> IOOf<B>): IO<B> = this
To leave the overridden function as explicit as it currently is I opted to elaborate in the
IOFrame
docs how to properly use it. Also, I added a test for this and changed the usage inIOBracket
.Do we want to keep it like this or shall we override
IO.RaiseError#flatMap
as follows to prevent similar bugs by miss-use in the future?