Skip to content

Use constant in the parse tree for minus + graphviz export handles constants #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

arnaud-m
Copy link
Owner

@arnaud-m arnaud-m requested a review from FissoreD November 17, 2022 10:48
Copy link
Collaborator

@FissoreD FissoreD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've seen your modifs.
And I really like your idea to put 0 before unary minus, because I have an idea to propose you next week about how we can do subtraction with bigNumm without moving subtrees on the other side of the equal.
For the moment my approach with minus has some bugs, but maybe you will find a trick to make it work (if my idea is not completely incohrent).
This week I've also thought about how we can implement also the NE operator with BigNum normally it should work.
For the PR it's good for me.

@arnaud-m
Copy link
Owner Author

  • I am curious to hear about your idea for handling minus.
  • Do not spend to much time on the ne operator. Inequalities will often have multiple solutions and therefore not considered as cryptarithms.

@arnaud-m arnaud-m merged commit c7d62a7 into main Nov 18, 2022
@arnaud-m arnaud-m deleted the constMinus branch November 18, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Remove question marks of constant in graphviz export [FEATURE] Use a constant in the parse tree for minus sign
2 participants