Skip to content

Refactor the interface ICryptaNode #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 16, 2022
Merged

Refactor the interface ICryptaNode #46

merged 14 commits into from
Nov 16, 2022

Conversation

arnaud-m
Copy link
Owner

No description provided.

@arnaud-m arnaud-m added the quality mprovements of code quality label Nov 15, 2022
@arnaud-m arnaud-m requested a review from FissoreD November 15, 2022 18:24
FissoreD
FissoreD reviewed Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@FissoreD FissoreD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand what you meant when you said to use polymorphism.
The code is a lot cleaner, I fact I'm not a fan of cast.

@arnaud-m arnaud-m merged commit b537d6e into main Nov 16, 2022
@arnaud-m arnaud-m deleted the refactorNode branch November 16, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FissoreD FissoreD FissoreD left review comments

Assignees
No one assigned
Labels
quality mprovements of code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud-m @FissoreD