Skip to content

Add AND #22 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 3, 2022
Merged

Add AND #22 #30

merged 14 commits into from
Nov 3, 2022

Conversation

margauxschmied
Copy link
Collaborator

No description provided.

arnaud-m
arnaud-m requested changes Nov 2, 2022
View reviewed changes
Copy link
Owner

@arnaud-m arnaud-m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. That is good, and carefully tested.

  • I have a few minor comment that must be addressed.
  • You must also add tests using the bignum model.
  • You must also update your branch, because I have released a new version,

@arnaud-m arnaud-m merged commit 1b1efd2 into main Nov 3, 2022
@arnaud-m arnaud-m deleted the addAnd branch November 3, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FissoreD FissoreD FissoreD approved these changes

@arnaud-m arnaud-m arnaud-m approved these changes

@Imp95 Imp95 Awaiting requested review from Imp95

@mpelleau mpelleau Awaiting requested review from mpelleau

Assignees

@margauxschmied margauxschmied

@FissoreD FissoreD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@margauxschmied @arnaud-m @FissoreD