Skip to content

Skip waiting for signed boarding ins/forfeit txs if none is required #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

altafan
Copy link
Collaborator

@altafan altafan commented Mar 17, 2025

This includes server-side optimization for the execution of the round:

  • Do not wait for the execution timeout to expire when a round doesn't contain boarding inputs or forfeit txs to be signed: this is a very edge case in which a round includes only users that are redeeming notes. In this case, users just need to sign the VTXO tree to complete the round execution. Before this, in such case, the server would have waited for the timeout to expire because clients wouldn't submit any signed boarding input or forfeit tx.
  • Add safe checks to SignRoundTx to prevent overriding a round tx if the user didn't submit any signed boarding input. Before this, a malicious client could have submitted an unsigned round tx to make the server loose all previous collected signed boarding inputs.

Closes #492.

Please @louisinger @sekulicd review.

@altafan altafan merged commit a2e2614 into arkade-os:master Mar 18, 2025
7 checks passed
@altafan altafan deleted the ignore-submitting-unsigned-round-tx branch March 18, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not update round tx if no signed boarding inputs have been submitted
2 participants