Skip to content

chore: make function comment match function name #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

chore: make function comment match function name #496

merged 1 commit into from
Mar 14, 2025

Conversation

avoidalone
Copy link
Contributor

make function comment match function name

tiero
tiero reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@tiero tiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kvdb and macaroons package are copy pasted from lnd AFAIK @altafan

@avoidalone
Copy link
Contributor Author

avoidalone commented Mar 14, 2025 •
edited
Loading

The kvdb and macaroons package are copy pasted from lnd AFAIK @altafan

Should I roll back my changes to this library?

@tiero
Copy link
Member

tiero commented Mar 14, 2025 •
edited
Loading

Apparently we also exported stuff on our own, so your changes are legitimate. Thank you for the contribution!

@tiero tiero merged commit d2bf89c into arkade-os:master Mar 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiero tiero tiero left review comments

@altafan altafan altafan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avoidalone @tiero @altafan