add ALLOW_ZERO_FEES flag
#437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altafan
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
ALLOW_ZERO_FEESflag for redeem transactions. It allows to submit redeem psbt with a zero fee value. It must be removed when we migrate to transaction V3 (#328). It's not ideal cause it makes the transaction not being relayed by full node from the onchain point of view, thus it's not possible to unilateral exit a zero-fee pending VTXO.It also adds a
withZeroFeeflag to covenantlessSendOffchainmethod. It prevents the transaction builder to deduct min-relay-fee amount from the last output.@tiero @bordalix @altafan please review