Skip to content

fix: remove unnecessary init container status checks. Fixes #14495 #14510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

jswxstw
Copy link
Member

@jswxstw jswxstw commented May 27, 2025

Fixes #14495

Motivation

Workflow stucks Running when initContainer in containerSet fails.

Modifications

Remove unnecessary init container status checks because pod will turn to Failed if init container fails.
All nodes including container node will be Failed if pod fails.

Verification

metadata:
  name: hello-world-containerset-initcontainerfails
spec:
  entrypoint: hello-world
  templates:
    - name: hello-world
      dag:
        tasks:
          - name: containerset
            template: containerset
    - name: containerset
      containerSet:
        containers:
          - name: hello
            image: alpine:latest
            command: [sh, -c]
            args: ["echo hello"]
          - name: world
            image: alpine:latest
            command: [sh, -c]
            args: ["echo world"]
      initContainers:
        - name: setup
          image: alpine:latest
          command: [sh, -c]
          args: ["echo intentional failure; exit 1"]

Clipboard_Screenshot_1748335986

Documentation

@jswxstw
Copy link
Member Author

jswxstw commented May 27, 2025

/retest

@isubasinghe isubasinghe merged commit cf4daad into argoproj:main May 28, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow hangs indefinitely when initContainer in containerSet fails
3 participants