fix: make argocd login respect the context name

[cardoe]

The argocd CLI login command does not respect the --argocd-context flag to name the context and always uses the name of the server. This makes it respect the flag and use the supplied context name. Removed check against empty ctxName which is done higher up already.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[cardoe]

relates to #19867 which will hopefully make this all the more complete

[cardoe]

The test failed performing a git operation unrelated to my change.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.05%. Comparing base (127eef9) to head (e6d0957).
Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/login.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #22643      +/-   ##
==========================================
- Coverage   56.06%   56.05%   -0.01%     
==========================================
  Files         343      343              
  Lines       57536    57535       -1     
==========================================
- Hits        32257    32254       -3     
- Misses      22634    22641       +7     
+ Partials     2645     2640       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cardoe]

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

The entire function where I made the change is uncovered.

[nitishfy]

Suggested change

	ctxName = globalClientOpts.Context
	ctxName = globalClientOpts.Context

why is this required? Shouldn't we get the ctxName value automatically from the flag itself?

[cardoe]

That global option is the flag where it's being read from. If it's not supplied then it's created.

[cardoe]

@nitishfy So today if you run argocd login argocd.my.host --sso --argocd-context my-argocd the context that gets created is called argocd.my.host and the option is ignored. The code path today sets the ctxName variable equal to the server name if its unset (which is always is). Then it performs some additional transformations on the ctxName variable. What I did was just default the ctxName to the command line flag in this change.

[nitishfy]

for setting the ctx, you can simply use the --name flag

[cardoe]

uhhh derp on my part @nitishfy.