Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not exclude APIService resources #22586

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Apr 7, 2025

APIService is not a transient or high churn resource, it is how you declare an aggregate API.

TODO: CHERRY PICK IN 3.0 RC

Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault requested review from a team as code owners April 7, 2025 10:38
Copy link

bunnyshell bot commented Apr 7, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault enabled auto-merge (squash) April 7, 2025 10:39
@crenshaw-dev
Copy link
Member

/cherry-pick release-3.0

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@a85a760). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #22586   +/-   ##
=========================================
  Coverage          ?   56.02%           
=========================================
  Files             ?      343           
  Lines             ?    57527           
  Branches          ?        0           
=========================================
  Hits              ?    32230           
  Misses            ?    22646           
  Partials          ?     2651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault agaudreault merged commit 76d1772 into argoproj:master Apr 7, 2025
28 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 7, 2025
crenshaw-dev pushed a commit that referenced this pull request Apr 7, 2025
Signed-off-by: Alexandre Gaudreault <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants