Skip to content

chore(deps): Update some dependencies versions (#22228) #22260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andrii-korotkov-verkada
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Mar 8, 2025

Helps with #22228

Bumped some versions.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner March 8, 2025 15:48
Copy link

bunnyshell bot commented Mar 8, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@andrii-korotkov-verkada andrii-korotkov-verkada changed the title chore(deps): Update some dependencies versions and bump go to 1.24.1 (#22228) chore(deps): Update some dependencies versions (#22228) Mar 8, 2025
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from 04def74 to 9f52056 Compare March 8, 2025 16:02
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@401e835). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/apiclient.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #22260   +/-   ##
=========================================
  Coverage          ?   55.90%           
=========================================
  Files             ?      343           
  Lines             ?    57332           
  Branches          ?        0           
=========================================
  Hits              ?    32054           
  Misses            ?    22639           
  Partials          ?     2639           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-korotkov-verkada
Copy link
Contributor Author

@github-project-automation github-project-automation bot moved this from Ready for final review to Changes Requested in Argo CD Review Mar 10, 2025
@andrii-korotkov-verkada
Copy link
Contributor Author

@crenshaw-dev
Copy link
Member

That's one option. But in each case we should have a good reason why we're adding the replace. The only justification I can think of is the presence of a high- or critical-severity vulnerability or a lower-severity vulnerability that's been shown to directly impact our users.

@andrii-korotkov-verkada
Copy link
Contributor Author

@crenshaw-dev, I've reverted the fork changes

@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from 9ed41d6 to ebdd52e Compare March 10, 2025 18:53
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from f70e0e1 to df83193 Compare March 10, 2025 19:38
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch 3 times, most recently from 606a740 to 35387e4 Compare March 14, 2025 18:06
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 14, 2025 18:15
auto-merge was automatically disabled March 14, 2025 21:53

Head branch was pushed to by a user without write access

@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch 2 times, most recently from 73802f4 to d8be262 Compare March 15, 2025 00:02
@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner March 15, 2025 15:52
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch 2 times, most recently from 1557f25 to 46a40ca Compare March 17, 2025 20:57
@andrii-korotkov-verkada
Copy link
Contributor Author

@crenshaw-dev, this one was rebased, previous not related changes removed and tests pass.

@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from 46a40ca to ab95be2 Compare March 21, 2025 15:30
@andrii-korotkov-verkada andrii-korotkov-verkada force-pushed the 22228-replace-some-dependencies-with-updated-versions-from-the-fork branch from ab95be2 to e4c3dfa Compare March 21, 2025 15:42
@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner March 21, 2025 15:42
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 21, 2025 16:03
@crenshaw-dev crenshaw-dev merged commit 6d63683 into argoproj:master Mar 21, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Changes Requested to Done in Argo CD Review Mar 21, 2025
@@ -60,4 +60,4 @@ argocd-applicationset-controller [flags]
--webhook-parallelism-limit int Number of webhook requests processed concurrently (default 50)
```

###### Auto generated by spf13/cobra on 20-Mar-2025
###### Auto generated by spf13/cobra on 21-Mar-2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrii-korotkov-verkada this line should be removed I think. After I rebased my PR, the Check nothing has changed step in CI is failing as this date gets updated and it complains this as a difference. I do not see this line in any other generated doc. https://github.com/argoproj/argo-cd/actions/runs/14007867560/job/39224004476?pr=21811

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root cause is not this PR, I have created this PR to address this issue by disabling auto-generated tag in the application set CLI command. PTAL.
#22446

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused due the change introduced in 22417

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandf I think the line is coming as part of autogeneration. I will see if we can remove that line manually and run make clidocsgen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandf @andrii-korotkov-verkada created PR #22449 to fix the issue

PaulSonOfLars pushed a commit to PaulSonOfLars/argo-cd that referenced this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants